Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make creation of new report not create extra files etc #22

Closed
dgkeyes opened this issue Apr 6, 2023 · 7 comments
Closed

Make creation of new report not create extra files etc #22

dgkeyes opened this issue Apr 6, 2023 · 7 comments
Assignees

Comments

@dgkeyes
Copy link
Member

dgkeyes commented Apr 6, 2023

From @OskaratOmni:

currently, if one uses a report template, additional materials are generated and stored in same directory as the file (e.g., skeleton.html). Can these either be routed to a folder (called ‘skeletons'?) or not generated at all if they are not needed.

likewise, when one makes a new document a new folder is made within the root folder. This can be inefficient because now the document is one level below the root folder and either other adjustments need to be made (to paths in the scripts, etc) or some cleanup and tidying has to happen. Ideally, use of a template would not change the folder hierarchy.

tvroylandt added a commit that referenced this issue Apr 7, 2023
@tvroylandt
Copy link
Collaborator

tvroylandt commented Apr 7, 2023

This are two issues in fact.

For the first one :

  • I wrapped everything possible in a custom format (which is now my standard way to do)
  • Put the materials in inst/assets
  • Plus did some cleaning

Note that this will still generate an images/ folder if you use the use_image option on the tables (TRUE by default).

I have an uncertainty about this still working with lof since Pandoc/pagedown version has changed in three years. (see rstudio/pagedown#280)

@tvroylandt
Copy link
Collaborator

This also solved the second issue by the same way. This was an odd behaviour of RStudio due to having many files in the template : rstudio/rstudio#3331

@OskaratOmni
Copy link
Collaborator

OskaratOmni commented Apr 10, 2023 via email

@tvroylandt
Copy link
Collaborator

Hi Oskar,

In fact, pagedown::html_paged()is built on top ofbookdown::html_document2()`. We then print it to pdf using the Chrome PDF printer.

I would definitely recommend bookdown when knitting to html or Word.

@dgkeyes
Copy link
Member Author

dgkeyes commented Apr 10, 2023

@tvroylandt can you please share instructions with @OskaratOmni on how he can install the dev branch of the package and test it out?

@tvroylandt
Copy link
Collaborator

Sure @OskaratOmni. You can use remotes::install_github("rfortherestofus/omni", branch = "dev", force = TRUE). Skip the updates since you should have them already in the right versions.

Then try to create a new report either through Rmd template or through the function. And tell me it it's works on your side (since packages versions and so may be different, it could not be the case) and fullfill your needs. In this case, just close the issue. Otherwise, tell me what's wrong here (by copying the error message) and I will investigate.

How does this sound ?

@OskaratOmni
Copy link
Collaborator

OskaratOmni commented Apr 12, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants