Skip to content

Commit

Permalink
ci(permerge): fix the pr-validation workflow (#849)
Browse files Browse the repository at this point in the history
- [x] add missing references to required steps for the premerge job;
  • Loading branch information
rfprod authored Jun 11, 2024
1 parent 9ad39f3 commit caf265c
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions .github/workflows/validate-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,7 @@ jobs:
run: echo "success='false'" >> $GITHUB_OUTPUT

premerge:
needs: [checks, lint, test, build]
needs: [checks, lint, lint-affected, test, test-affected, build, build-affected, build-affected-storybook]
if: always()
runs-on: ubuntu-latest

Expand All @@ -299,9 +299,9 @@ jobs:
echo "### :rocket: Premerge checks succeeded" >> $GITHUB_STEP_SUMMARY
env:
LINT_RESULT: ${{ needs.lint.outputs.success }}
LINT_AFFECTED_RESULT: ${{ needs.lint-affected.outputs.success || needs.checks.outputs.projects != '[]' }}
LINT_AFFECTED_RESULT: ${{ needs.lint-affected.outputs.success || 'true' }}
TEST_RESULT: ${{ needs.test.outputs.success }}
TEST_AFFECTED_RESULT: ${{ needs.test-affected.outputs.success || needs.checks.outputs.projects != '[]' }}
TEST_AFFECTED_RESULT: ${{ needs.test-affected.outputs.success || 'true' }}
BUILD_RESULT: ${{ needs.build.outputs.success }}
BUILD_AFFECTED_RESULT: ${{ needs.build-affected.outputs.success || needs.checks.outputs.projects-build != '[]' }}
BUILD_AFFECTED_STORYBOOK_RESULT: ${{ needs.build-affected-storybook.outputs.success || needs.checks.outputs.projects-build-storybook != '[]' }}
BUILD_AFFECTED_RESULT: ${{ needs.build-affected.outputs.success || 'true' }}
BUILD_AFFECTED_STORYBOOK_RESULT: ${{ needs.build-affected-storybook.outputs.success || 'true' }}

0 comments on commit caf265c

Please sign in to comment.