Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autoconfiguration broken for Spring Boot 3.0 #24

Closed
blulic opened this issue Feb 8, 2024 · 2 comments · Fixed by #25
Closed

Autoconfiguration broken for Spring Boot 3.0 #24

blulic opened this issue Feb 8, 2024 · 2 comments · Fixed by #25
Labels
enhancement
Milestone
2.0

Comments

@blulic
Copy link

blulic commented Feb 8, 2024 •
edited
Loading

For spring-boot-starter dependency, autoconfiguration is broken from Spring Boot 3.0.
Support for new autoconfiguration was introduced in Spring Boot 2.7 with the backward compatibility with the old auto-configuration approach via spring.factories.

From Spring Boot 3.0 support for spring.factories autoconfiguration was removed in favor of a new way.
Practically project requires a META-INF.spring directory with the file org.springframework.boot.autoconfigure.AutoConfiguration.imports and content: net.rgielen.fxweaver.spring.boot.autoconfigure.FxWeaverAutoConfiguration

I you agree, I could submit a PR with the fix for this, together with the dependency updates (Spring Boot 2.7 to support existing projects?).
@rgielen rgielen added this to the 4.0 milestone Feb 9, 2024
@rgielen
Copy link
Owner

rgielen commented Feb 9, 2024

Yes, please go ahead. I didn't have much time lately, but it's definitely time for a new release. This issue is super crucial for further usability, indeed.

blulic pushed a commit to blulic/javafx-weaver that referenced this issue Feb 11, 2024
@borislulicsncr
fixes rgielen#24
221af7d 
Added support for new Spring Boot 2.7+ autoconfiguration (mandatory for Spring Boot 3.0), updated other dependencies based on the Spring Boot 2.7.18
Tested with sample project and in personal project

Signed-off-by: blulic <boris.lulic@gmail.com>
@blulic blulic mentioned this issue Feb 11, 2024
Closed
@rgielen
Copy link
Owner

rgielen commented Feb 16, 2024

Thanks for the patch, I'm going to merge it the next few days. Sorry for being a bit busy 😆

@rgielen rgielen linked a pull request Jul 2, 2024 that will close this issue
#24 Support for new Spring Boot 2.7+ autoconfiguration #25
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
2.0
Development

Successfully merging a pull request may close this issue.

#24 Support for new Spring Boot 2.7+ autoconfiguration blulic/javafx-weaver
2 participants
@rgielen @blulic