fix: set the DOCTYPE by removing the DTD and creating a new one #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because GNOME/libxml2@8d0aaf4 prevents us from changing the node name in libxml >= 2.13.0. See discussion in #3230 for context.
flavorjones
added a commit
to sparklemotion/nokogiri
that referenced
this pull request
Jun 12, 2024
I want to make sure that we don't break the thing we're asking Sanitize to do; and I want to make sure we have valgrind coverage for it. See rgrove/sanitize#238 for context.
|
Also note that I've added a test of this workaround to Nokogiri's suite as well in sparklemotion/nokogiri#3230. |
flavorjones
force-pushed
the
flavorjones-handle-libxml-dtd-contraints
branch
from
e9fc1f0
to
49f7eed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the DOCTYPE to "html" by removing the DTD and creating a new one.
GNOME/libxml2@8d0aaf4 prevents us from changing the node name in libxml >= 2.13.0.
See discussion in #3230 for context.