fix: handle proxy watcher errors #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredallard
reviewed
May 18, 2024
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #149 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 11 11
Lines 578 596 +18
=====================================
- Misses 578 596 +18 ☔ View full report in Codecov by Sentry. |
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
jaredallard
approved these changes
May 18, 2024
|
@george-e-shaw-iv Do you mind signing your commits please? 🙇 |
george-e-shaw-iv
force-pushed
the
george-e-shaw-iv/fix/handle-proxy-errors
branch
from
64e8575
to
778986f
Compare
added 2 commits
May 18, 2024 15:07
* i saw the todo so i tried my hand at handling proxy watcher errors. it made me realize that the underlying mcnet library doesn't respect context very well at all which is probably one of the most important places to respect context actually. we should consider contributing back to that library to upgrade net.Listen to use net.ListenConfig which does respect context.
george-e-shaw-iv
force-pushed
the
george-e-shaw-iv/fix/handle-proxy-errors
branch
from
778986f
to
bd92681
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
made me realize that the underlying mcnet library doesn't respect
context very well at all which is probably one of the most important
places to respect context actually. we should consider contributing
back to that library to upgrade net.Listen to use net.ListenConfig
which does respect context.