Fix type inference regression in indirect dependency #156
+2,790
−2,154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Background Recert uses the `simple_asn1` crate in order to calculate the SKID on RSA keys # Problem The `simple_asn1` crate depends on the `time` crate, which recently encountered a regression [1] due to [2] that caused the `simple_asn1` crate to fail to compile with our locked version (0.3.30) of the `time` crate. # Solution Updated the `time` crate to version 0.3.36, which contains a fix for the regression. Re-ran vendoring. [1] time-rs/time#681 [2] rust-lang/rust#125319
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: omertuc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
/retest-required |
openshift-merge-bot
bot
merged commit 027c3e1
into
rh-ecosystem-edge:main
12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Recert uses the
simple_asn1crate in order to calculate the SKID on RSA keysProblem
The
simple_asn1crate depends on thetimecrate, which recently encountered a regression [1] due to [2] that caused thesimple_asn1crate to fail to compile with our locked version (0.3.30) of thetimecrate.Solution
Updated the
timecrate to version 0.3.36, which contains a fix for the regression. Re-ran vendoring.[1] time-rs/time#681
[2] rust-lang/rust#125319