Skip to content
This repository has been archived by the owner on Jul 23, 2024. It is now read-only.

FLPATH-340: propertyPath in update parameter response #291

Merged
merged 1 commit into from
May 5, 2023
Merged

FLPATH-340: propertyPath in update parameter response #291

merged 1 commit into from
May 5, 2023

Conversation

RichardW98
Copy link
Contributor

@RichardW98 RichardW98 commented May 1, 2023 •
edited
Loading

What this PR does / why we need it:
user needs to return propertyPath for dynamic parameters update. Validation on the parameters and propertyPath is also needed for UI

Which issue(s) this PR fixes :
Fixes #FLPATH-340

Change type

  • New feature
  • Bug fix
  • Unit tests
  • Integration tests
  • CI
  • Documentation
  • Auto generated SDK code

Impacted services

  • Workflow Service
  • Notifivcation Service

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented May 1, 2023 •
edited by openshift-ci bot
Loading

@RichardW98: This pull request references FLPATH-340 which is a valid jira issue.

In response to this:

What this PR does / why we need it:
user needs to return propertyPath for dynamic parameters update. Validation on the parameters and propertyPath is also needed for UI

Which issue(s) this PR fixes :
Fixes #FLPATH-340

Change type

  • New feature
  • Bug fix
  • Unit tests
  • Integration tests
  • CI
  • Documentation
  • Auto generated SDK code

Impacted services

  • Workflow Service
  • Notifivcation Service

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from eloycoto and nirarg May 1, 2023 04:17
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented May 1, 2023 •
edited by openshift-ci bot
Loading

@RichardW98: This pull request references FLPATH-340 which is a valid jira issue.

In response to this:

What this PR does / why we need it:
user needs to return propertyPath for dynamic parameters update. Validation on the parameters and propertyPath is also needed for UI

Which issue(s) this PR fixes :
Fixes #FLPATH-340

Change type

  • New feature
  • Bug fix
  • Unit tests
  • Integration tests
  • CI
  • Documentation
  • Auto generated SDK code

Impacted services

  • Workflow Service
  • Notifivcation Service

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented May 1, 2023 •
edited by openshift-ci bot
Loading

@RichardW98: This pull request references FLPATH-340 which is a valid jira issue.

In response to this:

What this PR does / why we need it:
user needs to return propertyPath for dynamic parameters update. Validation on the parameters and propertyPath is also needed for UI

Which issue(s) this PR fixes :
Fixes #FLPATH-340

Change type

  • New feature
  • Bug fix
  • Unit tests
  • Integration tests
  • CI
  • Documentation
  • Auto generated SDK code

Impacted services

  • Workflow Service
  • Notifivcation Service

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented May 1, 2023 •
edited by openshift-ci bot
Loading

@RichardW98: This pull request references FLPATH-340 which is a valid jira issue.

In response to this:

What this PR does / why we need it:
user needs to return propertyPath for dynamic parameters update. Validation on the parameters and propertyPath is also needed for UI

Which issue(s) this PR fixes :
Fixes #FLPATH-340

Change type

  • New feature
  • Bug fix
  • Unit tests
  • Integration tests
  • CI
  • Documentation
  • Auto generated SDK code

Impacted services

  • Workflow Service
  • Notifivcation Service

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented May 1, 2023 •
edited by openshift-ci bot
Loading

@RichardW98: This pull request references FLPATH-340 which is a valid jira issue.

In response to this:

What this PR does / why we need it:
user needs to return propertyPath for dynamic parameters update. Validation on the parameters and propertyPath is also needed for UI

Which issue(s) this PR fixes :
Fixes #FLPATH-340

Change type

  • New feature
  • Bug fix
  • Unit tests
  • Integration tests
  • CI
  • Documentation
  • Auto generated SDK code

Impacted services

  • Workflow Service
  • Notifivcation Service

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@RichardW98 RichardW98 force-pushed the FLPATH-340-propertyPath branch from 14216b3 to b39baf6 Compare May 1, 2023 15:29
@RichardW98 RichardW98 requested a review from anludke May 1, 2023 15:29
eloycoto
eloycoto reviewed May 2, 2023
View reviewed changes
...src/main/java/com/redhat/parodos/workflow/definition/parameter/WorkParameterServiceImpl.java Outdated
workFlowDefinition = workFlowDefinitionService.getParentWorkFlowByWorkName(workFlowDefinition.getName());
}

return WorkParameterValueResponseDTO.builder().key(workParameterValueResponse.getKey())
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we move this to a static method inside the DTO object?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

@RichardW98 RichardW98 force-pushed the FLPATH-340-propertyPath branch from b39baf6 to 1ff40d9 Compare May 2, 2023 13:44
pkliczewski
pkliczewski reviewed May 4, 2023
View reviewed changes
Copy link
Collaborator

@pkliczewski pkliczewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label May 4, 2023
@RichardW98 RichardW98 force-pushed the FLPATH-340-propertyPath branch from 1ff40d9 to 622e37c Compare May 4, 2023 18:14
@openshift-ci openshift-ci bot removed the lgtm label May 4, 2023
@RichardW98 RichardW98 force-pushed the FLPATH-340-propertyPath branch from 622e37c to 169b917 Compare May 4, 2023 18:20
@lshannon
Copy link
Contributor

lshannon commented May 5, 2023 •
edited by RichardW98
Loading

/approve

@lshannon
Copy link
Contributor

lshannon commented May 5, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm label May 5, 2023
@RichardW98 RichardW98 requested a review from lshannon May 5, 2023 13:36
anludke
anludke approved these changes May 5, 2023
View reviewed changes
Copy link
Contributor

@anludke anludke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented May 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anludke, lshannon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label May 5, 2023
@openshift-merge-robot openshift-merge-robot merged commit 6427db0 into rhdhorchestrator:main May 5, 2023
@RichardW98 RichardW98 deleted the FLPATH-340-propertyPath branch May 8, 2023 15:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pkliczewski pkliczewski pkliczewski left review comments

@anludke anludke anludke approved these changes

@nirarg nirarg Awaiting requested review from nirarg

@eloycoto eloycoto Awaiting requested review from eloycoto

@masayag masayag Awaiting requested review from masayag

@gciavarrini gciavarrini Awaiting requested review from gciavarrini

@lshannon lshannon Awaiting requested review from lshannon

Assignees

@pkliczewski pkliczewski

@lshannon lshannon

@anludke anludke

Labels
approved jira/valid-reference lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@RichardW98 @openshift-ci-robot @lshannon @eloycoto @pkliczewski @anludke @openshift-merge-robot