Skip to content
This repository has been archived by the owner on Jul 23, 2024. It is now read-only.

Organize imports according to spring formatter #306

Merged

Conversation

masayag
Copy link
Collaborator

@masayag masayag commented May 7, 2023

What this PR does / why we need it:
To reduce merge conflict, enforcing and organzing imports according to project's coding conventions is needed.

Project's coding conventions is spring's one:
https://github.com/spring-projects/spring-framework/wiki/Code-Style

The import statements are structured as follow:

import java.*
blank line
import javax.*
import jakarta.*
blank line
import all other imports
blank line
import org.springframework.*
blank line
import static all other imports

Change type

  • New feature
  • Bug fix
  • Unit tests
  • Integration tests
  • CI
  • Documentation
  • Auto-generated SDK code

Impacted services

  • Workflow Service
  • Notification Service

Checklist

  • Subject and description added to commit and PR.
  • Relevant issues have been referenced.

To reduce merge conflict, enforcing and organzing imports according to
project's coding conventions is needed.

Project's coding conventions is spring's one:
https://github.com/spring-projects/spring-framework/wiki/Code-Style

```
The import statements are structured as follow:

import java.*
blank line
import javax.*
import jakarta.*
blank line
import all other imports
blank line
import org.springframework.*
blank line
import static all other imports
```

Signed-off-by: Moti Asayag <masayag@redhat.com>
@openshift-ci openshift-ci bot requested review from anludke and ydayagi May 7, 2023 08:48
@masayag masayag requested a review from rgolangh May 7, 2023 09:06
@nirarg
Copy link
Contributor

nirarg commented May 7, 2023

/approve
/lgtm

@openshift-ci
Copy link

openshift-ci bot commented May 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nirarg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label May 7, 2023
@openshift-merge-robot openshift-merge-robot merged commit 47b14c7 into rhdhorchestrator:main May 7, 2023
@masayag masayag deleted the static_assert_imports branch May 7, 2023 14:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants