Skip to content
This repository has been archived by the owner on Jul 23, 2024. It is now read-only.

Code clean-ups #310

Merged
merged 1 commit into from
May 8, 2023
Merged

Conversation

masayag
Copy link
Collaborator

@masayag masayag commented May 7, 2023

What this PR does / why we need it:
Some code cleanups.

Change type

  • New feature
  • Bug fix
  • Unit tests
  • Integration tests
  • CI
  • Documentation
  • Auto generated SDK code

Impacted services

  • Workflow Service
  • Notifivcation Service

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.

@openshift-ci openshift-ci bot requested review from gciavarrini and ydayagi May 7, 2023 13:21
@masayag masayag requested a review from nirarg May 7, 2023 13:22
Moving from a deprecated method of defining test class to the common way.

Signed-off-by: Moti Asayag <masayag@redhat.com>
@nirarg
Copy link
Contributor

nirarg commented May 8, 2023

/approve
/lgtm

@openshift-ci
Copy link

openshift-ci bot commented May 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nirarg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label May 8, 2023
@openshift-merge-robot openshift-merge-robot merged commit a225ce4 into rhdhorchestrator:main May 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants