Skip to content
This repository has been archived by the owner on Jul 23, 2024. It is now read-only.

Unify *WorkStatus classes #315

Merged
merged 3 commits into from
May 8, 2023
Merged

Unify *WorkStatus classes #315

merged 3 commits into from
May 8, 2023

Conversation

masayag
Copy link
Collaborator

@masayag masayag commented May 7, 2023 •
edited
Loading

What this PR does / why we need it:
In order to unify API, a single work-status class is sufficient.
Therefore ParodosWorkStatus and WorfFlowStatus classes are being replaced with WorkStatus

Change type

  • New feature
  • Bug fix
  • Unit tests
  • Integration tests
  • CI
  • Documentation
  • Auto generated SDK code

Impacted services

  • Workflow Service
  • Notifivcation Service

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.

@openshift-ci openshift-ci bot requested review from anludke and lshannon May 7, 2023 19:50
@masayag masayag changed the title Remove ParodosWorkStatus class Unify *WorkStatus classes May 8, 2023
@masayag masayag requested review from pkliczewski and gciavarrini May 8, 2023 07:21
@openshift-ci
Copy link

openshift-ci bot commented May 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pkliczewski

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label May 8, 2023
masayag added 3 commits May 8, 2023 10:31
@masayag
Unify WorkStatus to a single class
78b5de0 
Signed-off-by: Moti Asayag <masayag@redhat.com>
@masayag
Add generated SDK files
69afbce 
Signed-off-by: Moti Asayag <masayag@redhat.com>
@masayag
Replace WorkFlowStatus with WorkStatus
9e1802f 
Signed-off-by: Moti Asayag <masayag@redhat.com>
gciavarrini
gciavarrini reviewed May 8, 2023
View reviewed changes
Copy link
Contributor

@gciavarrini gciavarrini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label May 8, 2023
@openshift-merge-robot openshift-merge-robot merged commit b16397f into rhdhorchestrator:main May 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gciavarrini gciavarrini gciavarrini left review comments

@pkliczewski pkliczewski pkliczewski approved these changes

@anludke anludke Awaiting requested review from anludke

@lshannon lshannon Awaiting requested review from lshannon

Assignees

@gciavarrini gciavarrini

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@masayag @pkliczewski @gciavarrini @openshift-merge-robot