Skip to content
This repository has been archived by the owner on Jul 23, 2024. It is now read-only.

FLPATH-303: workflow rollback #332

Merged
merged 1 commit into from
May 15, 2023
Merged

FLPATH-303: workflow rollback #332

merged 1 commit into from
May 15, 2023

Conversation

RichardW98
Copy link
Contributor

@RichardW98 RichardW98 commented May 9, 2023 •
edited
Loading

What this PR does / why we need it:

  1. User may want to rollback executions if the workflow is failed

  2. misleading swagger response with list:

Screenshot 2023-05-09 at 4 22 54 PM

Which issue(s) this PR fixes:
Fixes #FLPATH-303 #FLPATH-358

Change type

  • New feature
  • Bug fix
  • Unit tests
  • Integration tests
  • CI
  • Documentation
  • Auto-generated SDK code

Impacted services

  • Workflow Service
  • Notification Service

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented May 9, 2023 •
edited by openshift-ci bot
Loading

@RichardW98: This pull request references FLPATH-303 which is a valid jira issue.

In response to this:

What this PR does / why we need it:
User may want to rollback executions if the workflow is failed
Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story (FLPATH-xxxx):
Fixes #FLPATH-303

Change type

  • New feature
  • Bug fix
  • Unit tests
  • Integration tests
  • CI
  • Documentation
  • Auto-generated SDK code

Impacted services

  • Workflow Service
  • Notification Service

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from masayag and rgolangh May 9, 2023 20:17
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented May 9, 2023 •
edited by openshift-ci bot
Loading

@RichardW98: This pull request references FLPATH-303 which is a valid jira issue.

In response to this:

What this PR does / why we need it:
User may want to rollback executions if the workflow is failed
Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story (FLPATH-xxxx):
Fixes #FLPATH-303

Change type

  • New feature
  • Bug fix
  • Unit tests
  • Integration tests
  • CI
  • Documentation
  • Auto-generated SDK code

Impacted services

  • Workflow Service
  • Notification Service

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@RichardW98 RichardW98 force-pushed the FLPATH-303-rollback branch from aab6fc2 to 33bf328 Compare May 9, 2023 20:20
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented May 9, 2023 •
edited by openshift-ci bot
Loading

@RichardW98: This pull request references FLPATH-303 which is a valid jira issue.

In response to this:

What this PR does / why we need it:
User may want to rollback executions if the workflow is failed
Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story (FLPATH-xxxx):
Fixes #FLPATH-303 #FLPATH-358

Change type

  • New feature
  • Bug fix
  • Unit tests
  • Integration tests
  • CI
  • Documentation
  • Auto-generated SDK code

Impacted services

  • Workflow Service
  • Notification Service

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@RichardW98 RichardW98 requested a review from wKich May 9, 2023 20:22
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented May 9, 2023 •
edited by openshift-ci bot
Loading

@RichardW98: This pull request references FLPATH-303 which is a valid jira issue.

In response to this:

What this PR does / why we need it:

  1. User may want to rollback executions if the workflow is failed

  2. misleading swagger response with list:

Screenshot 2023-05-09 at 4 22 54 PM

Which issue(s) this PR fixes:
Fixes #FLPATH-303 #FLPATH-358

Change type

  • New feature
  • Bug fix
  • Unit tests
  • Integration tests
  • CI
  • Documentation
  • Auto-generated SDK code

Impacted services

  • Workflow Service
  • Notification Service

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@RichardW98 RichardW98 force-pushed the FLPATH-303-rollback branch from 33bf328 to 341edb6 Compare May 9, 2023 20:33
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented May 9, 2023 •
edited by openshift-ci bot
Loading

@RichardW98: This pull request references FLPATH-303 which is a valid jira issue.

In response to this:

What this PR does / why we need it:

  1. User may want to rollback executions if the workflow is failed

  2. misleading swagger response with list:

Screenshot 2023-05-09 at 4 22 54 PM

Which issue(s) this PR fixes:
Fixes #FLPATH-303 #FLPATH-358

Change type

  • New feature
  • Bug fix
  • Unit tests
  • Integration tests
  • CI
  • Documentation
  • Auto-generated SDK code

Impacted services

  • Workflow Service
  • Notification Service

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented May 9, 2023 •
edited by openshift-ci bot
Loading

@RichardW98: This pull request references FLPATH-303 which is a valid jira issue.

In response to this:

What this PR does / why we need it:

  1. User may want to rollback executions if the workflow is failed

  2. misleading swagger response with list:

Screenshot 2023-05-09 at 4 22 54 PM

Which issue(s) this PR fixes:
Fixes #FLPATH-303 #FLPATH-358

Change type

  • New feature
  • Bug fix
  • Unit tests
  • Integration tests
  • CI
  • Documentation
  • Auto-generated SDK code

Impacted services

  • Workflow Service
  • Notification Service

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented May 9, 2023 •
edited by openshift-ci bot
Loading

@RichardW98: This pull request references FLPATH-303 which is a valid jira issue.

In response to this:

What this PR does / why we need it:

  1. User may want to rollback executions if the workflow is failed

  2. misleading swagger response with list:

Screenshot 2023-05-09 at 4 22 54 PM

Which issue(s) this PR fixes:
Fixes #FLPATH-303 #FLPATH-358

Change type

  • New feature
  • Bug fix
  • Unit tests
  • Integration tests
  • CI
  • Documentation
  • Auto-generated SDK code

Impacted services

  • Workflow Service
  • Notification Service

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@RichardW98 RichardW98 force-pushed the FLPATH-303-rollback branch from 341edb6 to d9d6350 Compare May 9, 2023 21:01
pkliczewski
pkliczewski reviewed May 10, 2023
View reviewed changes
Copy link
Collaborator

@pkliczewski pkliczewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add rollback example and integration test.

How user can specify whether to run rollback or not?

@RichardW98
Copy link
Contributor Author

RichardW98 commented May 10, 2023 •
edited
Loading

Please add rollback example and integration test.

How user can specify whether to run rollback or not?

I will add some instruction in readme. I think whether to run rollback should be managed by workflow admin. Users are usually only interested in how they can make next workflow success, rather than the rollback process of failed workflow. Also same workflows should have the same rules to run rollback or not. so I think we don't need user to specify it from UI

@RichardW98 RichardW98 force-pushed the FLPATH-303-rollback branch 3 times, most recently from ee943f8 to 45aff49 Compare May 10, 2023 18:11
@RichardW98 RichardW98 requested a review from pkliczewski May 10, 2023 18:34
pkliczewski
pkliczewski reviewed May 11, 2023
View reviewed changes
Copy link
Collaborator

@pkliczewski pkliczewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label May 11, 2023
@RichardW98 RichardW98 force-pushed the FLPATH-303-rollback branch from 45aff49 to 0300040 Compare May 15, 2023 20:20
@openshift-ci openshift-ci bot removed the lgtm label May 15, 2023
@RichardW98 RichardW98 force-pushed the FLPATH-303-rollback branch from 0300040 to 5e12063 Compare May 15, 2023 20:39
@RichardW98 RichardW98 requested a review from pkliczewski May 15, 2023 21:25
anludke
anludke approved these changes May 15, 2023
View reviewed changes
Copy link
Contributor

@anludke anludke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label May 15, 2023
@openshift-ci
Copy link

openshift-ci bot commented May 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anludke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 5e9b033 into rhdhorchestrator:main May 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anludke anludke anludke approved these changes

@masayag masayag Awaiting requested review from masayag

@rgolangh rgolangh Awaiting requested review from rgolangh

@eloycoto eloycoto Awaiting requested review from eloycoto

@lshannon lshannon Awaiting requested review from lshannon

@gciavarrini gciavarrini Awaiting requested review from gciavarrini

@nirarg nirarg Awaiting requested review from nirarg

@wKich wKich Awaiting requested review from wKich

@pkliczewski pkliczewski Awaiting requested review from pkliczewski

Assignees

@pkliczewski pkliczewski

@anludke anludke

Labels
approved jira/valid-reference lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@RichardW98 @openshift-ci-robot @pkliczewski @anludke @openshift-merge-robot