This repository has been archived by the owner on Jul 23, 2024. It is now read-only.
FLPATH-394 - Speedup integration test execution #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/lgtm |
pkliczewski
reviewed
May 17, 2023
integration-tests/src/test/java/com/redhat/parodos/flows/base/BaseIntegrationTest.java
Outdated
Show resolved
Hide resolved
|
I noticed that many changes in this PR were pushed in #281. Is this intentional? |
@pkliczewski I added in this PR description "Depends on #281" I'd like to have an early review on this fix, that's why I opened this PR even if the #281 is not merged. |
gciavarrini
force-pushed
the
speedup-integrationtest
branch
from
890c4ec to
7982772
Compare
gciavarrini
force-pushed
the
speedup-integrationtest
branch
from
7982772 to
04327d6
Compare
Signed-off-by: Gloria Ciavarrini <gciavarrini@redhat.com>
gciavarrini
force-pushed
the
speedup-integrationtest
branch
from
04327d6 to
b00c268
Compare
Signed-off-by: Gloria Ciavarrini <gciavarrini@redhat.com>
gciavarrini
force-pushed
the
speedup-integrationtest
branch
from
b00c268 to
e57bfb9
Compare
masayag
approved these changes
May 17, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: masayag The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Integration tests execution currently requires 8m 40s ( see Run integration tests step) .
This PR drop the execution time to about 35 seconds (see Run integration tests of a developing branch).
Fixes FLPATH-394
Depends on #281
Change type
Impacted services
Checklist