Skip to content
This repository has been archived by the owner on Jul 23, 2024. It is now read-only.

Rename test class name to end with Test #345

Conversation

masayag
Copy link
Collaborator

@masayag masayag commented May 17, 2023

What this PR does / why we need it:
To match coding style, test classes should end with Test.

Change type

  • New feature
  • Bug fix
  • Unit tests
  • Integration tests
  • CI
  • Documentation
  • Auto-generated SDK code

Impacted services

  • Workflow Service
  • Notification Service

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.

@openshift-ci openshift-ci bot requested review from eloycoto and gciavarrini May 17, 2023 13:39
@gciavarrini
Copy link
Contributor

Thanks for fixing this!

/approve

Copy link
Collaborator

@pkliczewski pkliczewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label May 17, 2023
@masayag masayag force-pushed the rename_to_SimpleRollbackWorkFlowTest branch from b688b4e to 9c37c17 Compare May 17, 2023 13:53
@openshift-ci openshift-ci bot removed the lgtm label May 17, 2023
Signed-off-by: Moti Asayag <masayag@redhat.com>
@masayag masayag force-pushed the rename_to_SimpleRollbackWorkFlowTest branch from 9c37c17 to c8ded5b Compare May 17, 2023 15:41
@masayag masayag requested a review from pkliczewski May 17, 2023 15:51
Copy link
Contributor

@gciavarrini gciavarrini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link

openshift-ci bot commented May 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gciavarrini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nirarg
Copy link
Contributor

nirarg commented May 17, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm label May 17, 2023
@openshift-merge-robot openshift-merge-robot merged commit 54407ee into rhdhorchestrator:main May 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants