Skip to content
This repository has been archived by the owner on Jul 23, 2024. It is now read-only.

Extract shared code in integration-tests #361

Merged

Conversation

masayag
Copy link
Collaborator

@masayag masayag commented May 22, 2023

What this PR does / why we need it:
Each integration-tests that execute a workflow share the same structure:

  1. Create a project
  2. Verify workflow-definition exists
  3. Run a workflow

The projects are created the same and can be placed in a shared location in which the project creation is part of test initialization.

Change type

  • New feature
  • Bug fix
  • Unit tests
  • Integration tests
  • CI
  • Documentation
  • Auto-generated SDK code

Impacted services

  • Workflow Service
  • Notification Service

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.

@openshift-ci openshift-ci bot requested review from gciavarrini and lshannon May 22, 2023 13:42
@openshift-ci
Copy link

openshift-ci bot commented May 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pkliczewski

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Each integration-tests that execute a workflow share the same structure:
1. Create a project
2. Verify workflow-definition exists
3. Run a workflow

The projects are created the same and can be placed in a shared location
in which the project creation is part of test initialization.

Signed-off-by: Moti Asayag <masayag@redhat.com>
@masayag masayag force-pushed the integ_test_refactor branch from a52e35a to f0317d9 Compare May 22, 2023 15:50
@nirarg
Copy link
Contributor

nirarg commented May 22, 2023

/lgtm

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants