Skip to content
This repository has been archived by the owner on Jul 23, 2024. It is now read-only.

Refactor async execution methods #373

Merged

Conversation

masayag
Copy link
Collaborator

@masayag masayag commented May 25, 2023

What this PR does / why we need it:
This PR intends to improve readability and replace the long-growing list of parameters being passed to the workflow execution methods with a combination of a record and lombok builder.

Change type

  • New feature
  • Bug fix
  • Unit tests
  • Integration tests
  • CI
  • Documentation
  • Auto-generated SDK code

Impacted services

  • Workflow Service
  • Notification Service

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.

Signed-off-by: Moti Asayag <masayag@redhat.com>
@openshift-ci openshift-ci bot requested review from pkliczewski and rgolangh May 25, 2023 08:55
@masayag masayag requested review from gciavarrini and RichardW98 May 25, 2023 08:55
@gciavarrini
Copy link
Contributor

Overall this PR lgtm.
Do you think it's worth adding a description in README or website documentation to explain how to add a parameter to the workflow execution?

@masayag
Copy link
Collaborator Author

masayag commented May 25, 2023

Overall this PR lgtm. Do you think it's worth adding a description in README or website documentation to explain how to add a parameter to the workflow execution?

I don't think it is needed. that's an implementation detail and seems more aligned with the rest of the code and that uses the builder pattern.

@gciavarrini
Copy link
Contributor

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented May 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pkliczewski

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 2a03933 into rhdhorchestrator:main May 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants