Skip to content
This repository has been archived by the owner on Jul 23, 2024. It is now read-only.

Refactor rollback execution #374

Conversation

masayag
Copy link
Collaborator

@masayag masayag commented May 25, 2023

What this PR does / why we need it:
In order to provide more logging around rollback workflow execution, the code is refactored.
In addition, it will enable the support of linked-rollbacks if it will be needed by simple additional work.

Change type

  • New feature
  • Bug fix
  • Unit tests
  • Integration tests
  • CI
  • Documentation
  • Auto-generated SDK code

Impacted services

  • Workflow Service
  • Notification Service

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.

In order to provide more logging around rollback workflow execution, the
code is refactored.

In addition, it will enable the supported of linked-rollbacks if it will
be needed by a simple additional work.

Signed-off-by: Moti Asayag <masayag@redhat.com>
@openshift-ci openshift-ci bot requested review from nirarg and pkliczewski May 25, 2023 10:49
@masayag masayag requested review from gciavarrini and RichardW98 May 25, 2023 10:49
@openshift-ci
Copy link

openshift-ci bot commented May 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RichardW98

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gciavarrini
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label May 25, 2023
@openshift-merge-robot openshift-merge-robot merged commit 6af518e into rhdhorchestrator:main May 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants