Skip to content
This repository has been archived by the owner on Jul 23, 2024. It is now read-only.

FLPATH-377: fix log not found #390

Merged

Conversation

RichardW98
Copy link
Contributor

What this PR does / why we need it:
this pr fixes an error that log endpoint returning 404 when task has no log
Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story (FLPATH-xxxx):
Fixes #377

Change type

  • New feature
  • Bug fix
  • Unit tests
  • Integration tests
  • CI
  • Documentation
  • Auto-generated SDK code

Impacted services

  • Workflow Service
  • Notification Service

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented May 30, 2023

@RichardW98: This pull request references FLPATH-377 which is a valid jira issue.

In response to this:

What this PR does / why we need it:
this pr fixes an error that log endpoint returning 404 when task has no log
Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story (FLPATH-xxxx):
Fixes #377

Change type

  • New feature
  • Bug fix
  • Unit tests
  • Integration tests
  • CI
  • Documentation
  • Auto-generated SDK code

Impacted services

  • Workflow Service
  • Notification Service

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from rgolangh and ydayagi May 30, 2023 19:14
@RichardW98 RichardW98 requested review from masayag, eloycoto, anludke, rgolangh and gciavarrini and removed request for rgolangh and ydayagi May 30, 2023 19:14
Copy link
Contributor

@anludke anludke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented May 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anludke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit d5eab82 into rhdhorchestrator:main May 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants