Add task for deploying application manifests #392
Conversation
prebuilt-tasks/src/main/java/com/redhat/parodos/tasks/application/DeployApplicationTask.java
Outdated
Show resolved
Hide resolved
prebuilt-tasks/src/main/java/com/redhat/parodos/tasks/application/DeployApplicationTask.java
Outdated
Show resolved
Hide resolved
prebuilt-tasks/src/main/java/com/redhat/parodos/tasks/application/DeployApplicationTask.java
Outdated
Show resolved
Hide resolved
@eloycoto before writing tests, I wanted to make sure the expectation for the input parameters is correct |
Overall LGTM, maybe I'll move the set manifest to a public function; I can think of extending the class without parameters and deploying the manifest directly into it. |
masayag
force-pushed
the
m2k_deploy_app
branch
2 times, most recently
from
8d6bcfd to
bf22896
Compare
The PR adds a workflow task to read manifests from a given path and apply them to OCP cluster. Once the resources are applied, the work context should be updated with the routers to the deployed application. Signed-off-by: Moti Asayag <masayag@redhat.com>
feel free to modify the code as you see once it is merged to satisfy the needs of the next evolution of it, or let me know what you'd like me to change. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eloycoto The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@ydayagi it would be good to use this client instead |
What this PR does / why we need it:
The PR adds a workflow task to read manifests from a given path and apply them to OCP cluster.
Once the resources are applied, the work context should be updated with the routers to the deployed application.
Which issue(s) this PR fixes:
Fixes FLPATH-411
Change type
Impacted services
Checklist