This repository has been archived by the owner on Jul 23, 2024. It is now read-only.
Add delay between attempts of invoking requests #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masayag
force-pushed
the
add_delay_between_attempts
branch
from
7780b6a to
936e57f
Compare
With the current implementation, the client intensively sends requests to the workflow service if the former request failed. This intensity leads to high CPU consumption which impacts both client and mainly the server. By adding a small timeout between failed requests, the chance for completing a workflow increases and so the resource consumption drops significantly (20% CPU vs over 100%). This is a temporary fix before replacing the current implementation with Executor service and future. Signed-off-by: Moti Asayag <masayag@redhat.com>
masayag
force-pushed
the
add_delay_between_attempts
branch
from
936e57f to
95a3ec5
Compare
RichardW98
approved these changes
Jun 5, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RichardW98 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
With the current implementation, the client intensively sends requests to the workflow service if the former request failed. This intensity leads to high CPU consumption which impacts both client and mainly the server.
By adding a small timeout between failed requests, the chance for completing a workflow increases and so the resource consumption drops significantly (4-5% CPU vs over 100%).
This is a temporary fix before replacing the current implementation with Executor service and future.
Which issue(s) this PR fixes (optional, use
fixes #<issue_number>(, fixes #<issue_number>, ...)format, where issue_number might be a GitHub issue, or a Jira story (FLPATH-xxxx):Fixes #FLPATH-433
Change type
Impacted services
Checklist