Skip to content
This repository has been archived by the owner on Jul 23, 2024. It is now read-only.

Remove duplicated jgit dependency #438

Conversation

gciavarrini
Copy link
Contributor

What this PR does / why we need it:
Delete duplicate dependency declaration in prebuilt-tasks pom

Change type

  • New feature
  • Bug fix
  • Unit tests
  • Integration tests
  • CI
  • Documentation
  • Auto-generated SDK code

Impacted services

  • Workflow Service
  • Notification Service

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.

@openshift-ci openshift-ci bot requested review from lshannon and masayag June 15, 2023 15:50
@@ -129,12 +129,6 @@
<version>1.73</version>
</dependency>

<dependency>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls remove duplicate entry from workflow-service/pom.xml as well

Signed-off-by: Gloria Ciavarrini <gciavarrini@redhat.com>
@gciavarrini gciavarrini force-pushed the fix-dup-jgit-dependecy branch from 1d26d8e to 78584d1 Compare June 15, 2023 15:58
@gciavarrini
Copy link
Contributor Author

/hold

do not merge until monday

@masayag
Copy link
Collaborator

masayag commented Jun 15, 2023

/lgtm

@gciavarrini
Copy link
Contributor Author

/unhold

@masayag
Copy link
Collaborator

masayag commented Jun 15, 2023

/approve

@openshift-ci
Copy link

openshift-ci bot commented Jun 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: masayag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit aa3fb9e into rhdhorchestrator:main Jun 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants