Skip to content
This repository has been archived by the owner on Jul 23, 2024. It is now read-only.

[FLPATH-470] Restart workflow - backend #444

Conversation

gabriel-farache
Copy link
Contributor

@gabriel-farache gabriel-farache commented Jun 16, 2023

What this PR does / why we need it:
This PR introduces the restart workflow feature.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story (FLPATH-xxxx):
Fixes #FLPATH-470

Change type

  • New feature
  • Bug fix
  • Unit tests
  • Integration tests
  • CI
  • Documentation
  • Auto-generated SDK code

Impacted services

  • Workflow Service
  • Notification Service

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.

@gabriel-farache gabriel-farache force-pushed the feat/restart_workflow-backend branch from 1ef3253 to 224b9e4 Compare June 23, 2023 09:29
@gabriel-farache gabriel-farache force-pushed the feat/restart_workflow-backend branch 4 times, most recently from 1bc352e to 57df709 Compare June 26, 2023 13:06
@gabriel-farache gabriel-farache marked this pull request as ready for review June 26, 2023 13:57
@openshift-ci openshift-ci bot requested review from masayag and pkliczewski June 26, 2023 13:57
@gabriel-farache gabriel-farache force-pushed the feat/restart_workflow-backend branch from 57df709 to c35f7f0 Compare June 26, 2023 14:31
@masayag
Copy link
Collaborator

masayag commented Jun 27, 2023

@gabriel-farache pls note that the build failure is related to the new integration test. Other than that, the PR looks good to me.

@gabriel-farache gabriel-farache force-pushed the feat/restart_workflow-backend branch from 0575778 to f367e22 Compare June 27, 2023 12:43
@masayag
Copy link
Collaborator

masayag commented Jun 27, 2023

/approve

@openshift-ci
Copy link

openshift-ci bot commented Jun 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: masayag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gabriel-farache gabriel-farache force-pushed the feat/restart_workflow-backend branch from f367e22 to da74fc1 Compare June 28, 2023 12:22
@masayag
Copy link
Collaborator

masayag commented Jun 28, 2023

/lgtm

@masayag
Copy link
Collaborator

masayag commented Jun 29, 2023

@gabriel-farache pls rebase

@gabriel-farache gabriel-farache force-pushed the feat/restart_workflow-backend branch 2 times, most recently from 1e1df83 to bc5c930 Compare July 3, 2023 14:34
@masayag
Copy link
Collaborator

masayag commented Jul 3, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jul 3, 2023
@gabriel-farache gabriel-farache force-pushed the feat/restart_workflow-backend branch from bc5c930 to 43e41ad Compare July 3, 2023 15:10
@openshift-ci openshift-ci bot removed the lgtm label Jul 3, 2023
@gabriel-farache gabriel-farache force-pushed the feat/restart_workflow-backend branch from 43e41ad to 48a051e Compare July 3, 2023 20:41
@gciavarrini
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jul 4, 2023
@openshift-merge-robot openshift-merge-robot merged commit 02c5d4f into rhdhorchestrator:main Jul 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants