This repository has been archived by the owner on Jul 23, 2024. It is now read-only.
Fix bug in context arguments merge #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masayag
force-pushed
the
retain_origin_param
branch
2 times, most recently
from
fd8d89a to
69d4ce8
Compare
The PR fixes a bug that caused only the first argument to be stored in the target work context. In addition, the precedence of the merged arguments is defined as: * Target workflow arguments * Source workflow arguments from their context by key WORKFLOW_EXECUTION_ARGUMENTS * Source workflow arguments Signed-off-by: Moti Asayag <masayag@redhat.com>
masayag
force-pushed
the
retain_origin_param
branch
from
69d4ce8 to
7c33656
Compare
eloycoto
approved these changes
Jun 19, 2023
RichardW98
approved these changes
Jun 19, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eloycoto, RichardW98 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The PR fixes a bug that caused only the first argument to be stored in the target work context.
In addition, the precedence of the merged arguments is defined as:
Which issue(s) this PR fixes (optional, use
fixes #<issue_number>(, fixes #<issue_number>, ...)format, where issue_number might be a GitHub issue, or a Jira story (FLPATH-xxxx):Fixes #FLPATH-458
Change type
Impacted services
Checklist