Skip to content
This repository has been archived by the owner on Jul 23, 2024. It is now read-only.

FLPATH-474: fix getIdentity result & getPath test #455

Merged
merged 1 commit into from
Jun 22, 2023

Conversation

RichardW98
Copy link
Contributor

@RichardW98 RichardW98 commented Jun 21, 2023

What this PR does / why we need it:
address comments from #446
Which issue(s) this PR fixes:
Fixes #474

Change type

  • New feature
  • Bug fix
  • Unit tests
  • Integration tests
  • CI
  • Documentation
  • Auto-generated SDK code

Impacted services

  • Workflow Service
  • Notification Service

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Jun 21, 2023

@RichardW98: This pull request references FLPATH-474 which is a valid jira issue.

In response to this:

What this PR does / why we need it:
address comments from #446
Which issue(s) this PR fixes:
Fixes #474

Change type

  • New feature
  • Bug fix
  • Unit tests
  • Integration tests
  • CI
  • Documentation
  • Auto-generated SDK code

Impacted services

  • Workflow Service
  • Notification Service

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from gciavarrini and masayag June 21, 2023 18:22
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Jun 21, 2023

@RichardW98: This pull request references FLPATH-474 which is a valid jira issue.

In response to this:

What this PR does / why we need it:
address comments from #446
Which issue(s) this PR fixes:
Fixes #474

Change type

  • New feature
  • Bug fix
  • Unit tests
  • Integration tests
  • CI
  • Documentation
  • Auto-generated SDK code

Impacted services

  • Workflow Service
  • Notification Service

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@masayag
Copy link
Collaborator

masayag commented Jun 22, 2023

/lgtm

@gciavarrini
Copy link
Contributor

/approve

@openshift-ci
Copy link

openshift-ci bot commented Jun 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gciavarrini, masayag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [gciavarrini,masayag]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 412c094 into rhdhorchestrator:main Jun 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants