This repository has been archived by the owner on Jul 23, 2024. It is now read-only.
feat: backstage manifests using single namespace #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using backstage in other namespace, just don't use, this will allow to deploy multiple instances in different namespaces: Like: ``` kubectl kustomize hack/manifests/backstage/ | kubectl apply -n differentOne -f - ``` Or in default: ``` kubectl kustomize hack/manifests/backstage/ | kubectl apply -n default -f - ``` Fix FLPATH-511 Signed-off-by: Eloy Coto <eloy.coto@acalustra.com>
eloycoto
added a commit
to eloycoto/parodos.github.io
that referenced
this pull request
Jul 4, 2023
according to the changes introduced by this PR: rhdhorchestrator/parodos#467 Signed-off-by: Eloy Coto <eloy.coto@acalustra.com>
|
/lgtm |
masayag
reviewed
Jul 4, 2023
| @@ -60,5 +60,5 @@ spec: | |||
| httpGet: | |||
| path: /actuator/health | |||
| port: 8080 | |||
| initialDelaySeconds: 25 | |||
| initialDelaySeconds: 40 | |||
There was a problem hiding this comment.
is this related to the PR? meaning, does not having a specified namespace require more time or this is needed for other issue?
masayag
approved these changes
Jul 4, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: masayag The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using backstage in other namespace, just don't use, this will allow to deploy multiple instances in different namespaces:
Like:
Or in default:
Fix FLPATH-511