Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phpcs improvements #246

Merged
merged 96 commits into from
Aug 16, 2020
Merged
Show file tree
Hide file tree
Changes from 90 commits
Commits
Show all changes
96 commits
Select commit Hold shift + click to select a range
0ec36ce
phpcbf auto fixes
naxvog Aug 15, 2020
2ecd954
added property and method comments
naxvog Aug 15, 2020
ad7a2be
ignore phpcs error_log function sniff
naxvog Aug 15, 2020
c1c2ed5
Added html comment output escaping
naxvog Aug 15, 2020
a7c2928
yoda style conditions
naxvog Aug 15, 2020
4903859
Added additional output escaping for admin notices
naxvog Aug 15, 2020
1a04958
strict comparisson for in_array
naxvog Aug 15, 2020
a6d09bc
avoided assignments in comparisons
naxvog Aug 15, 2020
3a4a741
changed script loading position to footer
naxvog Aug 15, 2020
6a16184
added additional sanitization and nonces
naxvog Aug 15, 2020
36eef2c
switched to strict comparison
naxvog Aug 15, 2020
ff51724
ignored warning & added todo for `serialize` function
naxvog Aug 15, 2020
c6eed5b
one function argument per line
naxvog Aug 15, 2020
75a7248
ui tab abstraction
naxvog Aug 15, 2020
2612222
diagnostics output escaping
naxvog Aug 15, 2020
e3dbe9f
added documentation for QM classes
naxvog Aug 15, 2020
9caaefd
added output escaping + ignore statements
naxvog Aug 15, 2020
dc707f9
ignore file naming convention due to class definition in drop-in
naxvog Aug 15, 2020
c49ef48
fixed indentation issue
naxvog Aug 15, 2020
aa2c843
fixed precision alignment issues
naxvog Aug 15, 2020
a8b3c75
Added and improved documentation
naxvog Aug 15, 2020
9ea70de
phpcs ignores
naxvog Aug 15, 2020
8877d73
method name fixes
naxvog Aug 15, 2020
b079844
yoda style conditions
naxvog Aug 15, 2020
a02aed8
comment typo
naxvog Aug 15, 2020
b416210
use `wp_parse_url` for better compatibility
naxvog Aug 15, 2020
ae147cc
strict comparisons
naxvog Aug 15, 2020
2cc0e50
fixed formatting
naxvog Aug 15, 2020
aa74eca
fixed wrong return type
naxvog Aug 15, 2020
b659d13
output sanitization
naxvog Aug 15, 2020
57ce2b3
removed unnecessary php version checks for <= 5.6
naxvog Aug 15, 2020
f24b127
extra line
tillkruss Aug 15, 2020
656cabf
extra line
tillkruss Aug 15, 2020
e306b22
:facepalm: unfumbled the WP_REDIS_DISABLED check of the drop-in
naxvog Aug 15, 2020
2e3acd5
Merge branch 'phpcs_improvements' of github.com:naxvog/redis-cache in…
naxvog Aug 15, 2020
27a0c2f
simplified password obfuscation
naxvog Aug 15, 2020
cef2388
dropped output sanitization for static comment
naxvog Aug 15, 2020
48b81ea
resolved cache size calc issue + unified method
naxvog Aug 15, 2020
04d131c
marked WP_Object_Cache::stats deprecated
naxvog Aug 15, 2020
7658068
Revert "yoda style conditions"
naxvog Aug 15, 2020
bcaabc5
Revert "yoda style conditions"
naxvog Aug 15, 2020
c52790b
removed yoda style condition checks from phpcs ruleset
naxvog Aug 15, 2020
5a2ec01
reverted deprecation and added explanation
naxvog Aug 15, 2020
eb4cb48
reverted WP_REDIS_DISABLED shorthand
naxvog Aug 16, 2020
09df910
removed indentation sniff due to non standard indentation
naxvog Aug 16, 2020
028232c
phpcbf auto fixes
naxvog Aug 15, 2020
f40baa9
added property and method comments
naxvog Aug 15, 2020
044fcb6
ignore phpcs error_log function sniff
naxvog Aug 15, 2020
8f9c408
Added html comment output escaping
naxvog Aug 15, 2020
712cac8
yoda style conditions
naxvog Aug 15, 2020
b545a83
Added additional output escaping for admin notices
naxvog Aug 15, 2020
5abb752
strict comparisson for in_array
naxvog Aug 15, 2020
319f2b0
avoided assignments in comparisons
naxvog Aug 15, 2020
c85d4f9
changed script loading position to footer
naxvog Aug 15, 2020
94f2c35
added additional sanitization and nonces
naxvog Aug 15, 2020
d32973e
switched to strict comparison
naxvog Aug 15, 2020
1af9dcf
ignored warning & added todo for `serialize` function
naxvog Aug 15, 2020
fbd962b
one function argument per line
naxvog Aug 15, 2020
f556a5f
ui tab abstraction
naxvog Aug 15, 2020
5ce24cf
diagnostics output escaping
naxvog Aug 15, 2020
5565c31
added documentation for QM classes
naxvog Aug 15, 2020
ccaa205
added output escaping + ignore statements
naxvog Aug 15, 2020
408b746
ignore file naming convention due to class definition in drop-in
naxvog Aug 15, 2020
cfaacda
fixed indentation issue
naxvog Aug 15, 2020
b64717b
fixed precision alignment issues
naxvog Aug 15, 2020
3ebae67
Added and improved documentation
naxvog Aug 15, 2020
28147b2
phpcs ignores
naxvog Aug 15, 2020
b1c4fc9
method name fixes
naxvog Aug 15, 2020
c0072a6
yoda style conditions
naxvog Aug 15, 2020
efb9272
comment typo
naxvog Aug 15, 2020
5a0dc13
use `wp_parse_url` for better compatibility
naxvog Aug 15, 2020
aa2db7c
strict comparisons
naxvog Aug 15, 2020
c418f3d
fixed formatting
naxvog Aug 15, 2020
698a30f
fixed wrong return type
naxvog Aug 15, 2020
de709aa
output sanitization
naxvog Aug 15, 2020
2c574a7
removed unnecessary php version checks for <= 5.6
naxvog Aug 15, 2020
28246dc
:facepalm: unfumbled the WP_REDIS_DISABLED check of the drop-in
naxvog Aug 15, 2020
1a48aae
extra line
tillkruss Aug 15, 2020
2bed259
extra line
tillkruss Aug 15, 2020
bf62405
simplified password obfuscation
naxvog Aug 15, 2020
261b52c
dropped output sanitization for static comment
naxvog Aug 15, 2020
0370cbe
resolved cache size calc issue + unified method
naxvog Aug 15, 2020
0200faf
marked WP_Object_Cache::stats deprecated
naxvog Aug 15, 2020
aa449ef
Revert "yoda style conditions"
naxvog Aug 15, 2020
ebb7f1f
Revert "yoda style conditions"
naxvog Aug 15, 2020
ef1ea74
removed yoda style condition checks from phpcs ruleset
naxvog Aug 15, 2020
9de3854
reverted deprecation and added explanation
naxvog Aug 15, 2020
49b05b4
reverted WP_REDIS_DISABLED shorthand
naxvog Aug 16, 2020
812683b
removed indentation sniff due to non standard indentation
naxvog Aug 16, 2020
d16c400
Merge branch 'phpcs_improvements' of github.com:naxvog/redis-cache in…
naxvog Aug 16, 2020
9408397
new line
tillkruss Aug 16, 2020
3e510a6
new line
tillkruss Aug 16, 2020
68d2d29
new line
tillkruss Aug 16, 2020
8307a7b
added esc_textarea
naxvog Aug 16, 2020
3102d91
restored ternary whitespaces
naxvog Aug 16, 2020
7f4358b
Merge branch 'phpcs_improvements' of github.com:naxvog/redis-cache in…
naxvog Aug 16, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion assets/js/admin.js
Original file line number Diff line number Diff line change
Expand Up @@ -449,9 +449,12 @@
function ( event ) {
event.preventDefault();

var $parent = $( this ).parent();

$.post( ajaxurl, {
notice: $( this ).parent().attr( 'data-dismissible' ),
notice: $parent.data( 'dismissible' ),
action: 'roc_dismiss_notice',
_ajax_nonce: $parent.data( 'nonce' ),
} );
}
);
Expand Down
Loading