feat: remove unneeded mutability #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was flagged by spotbugs as EI_EXPOSE_REP and EI_EXPOSE_REP2, but since the fix means that setting the preferences on a Validation by copying it (and then using the copy) is now easier than it used to be for dependent code, the fix for these is being treated as a feature enhancement, not as a bug fix (the original code was package private or protected, so it was mostly internal).
If you have subclassed
JInputVerifierand are setting the preferences on a Validation in your subclass, replace code likethis.setValidationPreferences(this.myValidation);withthis.myValidation = new Validation(this.myValidation, this.getPreferences());