dump errors to debug log which were found in cleanup

rhysd · Jul 16, 2021 · 6eb960c · 6eb960c
1 parent ba6fc4e
commit 6eb960c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/rule_pyflakes.go b/rule_pyflakes.go
@@ -116,7 +116,9 @@ func (rule *RulePyflakes) VisitStep(n *Step) error {
 
 // Cleanup is callback when visiting finished. This callback is called even if the visiting failed since some callback returned an error
 func (rule *RulePyflakes) Cleanup() {
-	rule.group.Wait() // Ensure all processes ended
+	if err := rule.group.Wait(); err != nil { // Ensure all processes ended
+		rule.debug("error found while cleanup: %s", err)
+	}
 }
 
 func (rule *RulePyflakes) isPythonShell(r *ExecRun) bool {

diff --git a/rule_shellcheck.go b/rule_shellcheck.go
@@ -124,7 +124,9 @@ func (rule *RuleShellcheck) VisitWorkflowPost(n *Workflow) error {
 
 // Cleanup is callback when visiting finished. This callback is called even if the visiting failed since some callback returned an error
 func (rule *RuleShellcheck) Cleanup() {
-	rule.group.Wait() // Ensure all processes ended
+	if err := rule.group.Wait(); err != nil { // Ensure all processes ended
+		rule.debug("error found while cleanup: %s", err)
+	}
 }
 
 func (rule *RuleShellcheck) getShellName(exec *ExecRun) string {