fix job outputs are only passed to children (fix #151)

rule_expression.go

@@ -795,7 +795,7 @@ func (rule *RuleExpression) populateDependantNeedsTypes(out *ObjectType, job *Jo
 			"result":  StringType{},
 		})
 
-		rule.populateDependantNeedsTypes(out, j, root) // Add necessary needs props recursively
+		// Do not collect outputs type from parent of parent recursively. (#151)
 	}
 }
 

testdata/err/issue151_child_of_child_job.out

@@ -0,0 +1 @@
+/test\.yaml:26:31: property "first" is not defined in object type {second: {.*outputs: {second: string}.*}} \[expression\]/

testdata/err/issue151_child_of_child_job.yaml

@@ -0,0 +1,26 @@
+name: Test
+
+on: push
+
+jobs:
+  first:
+    runs-on: ubuntu-latest
+    outputs:
+      first: 'output from parent'
+    steps:
+      - run: echo 'first'
+
+  second:
+    needs: [first]
+    runs-on: ubuntu-latest
+    outputs:
+      second: 'output from second'
+    steps:
+      - run: echo 'second'
+
+  third:
+    needs: [second]
+    runs-on: ubuntu-latest
+    steps:
+      - run: echo '${{ toJSON(needs.second.outputs) }}'
+      - run: echo '${{ toJSON(needs.first.outputs) }}'

testdata/ok/issue-151-child-of-child-job.yaml

@@ -0,0 +1,26 @@
+name: Test
+
+on: push
+
+jobs:
+  first:
+    runs-on: ubuntu-latest
+    outputs:
+      first: 'output from parent'
+    steps:
+      - run: echo 'first'
+
+  second:
+    needs: [first]
+    runs-on: ubuntu-latest
+    outputs:
+      second: 'output from second'
+    steps:
+      - run: echo 'second'
+
+  third:
+    needs: [first, second]
+    runs-on: ubuntu-latest
+    steps:
+      - run: echo '${{ toJSON(needs.second.outputs) }}'
+      - run: echo '${{ toJSON(needs.first.outputs) }}'