Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#112 Column default functions sql error #116

Merged
merged 1 commit into from
Feb 9, 2024
Merged

#112 Column default functions sql error #116

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions src/ddl/ddl-builder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ import { GrantOn, GrantOptions } from './grant';
import { TruncateOptions } from './truncate';
import { DatabaseQueryBuilder } from '../dml';
import { Expression, isExpressionToken } from '../expression';
import { DatabaseFunctionToken, isDatabaseFunction } from '../functions';
import { DatabaseFunctionKeys } from '../functions/function-token';

export class DataDefinitionBuilder extends StatementBuilder {
protected columnTypes = ColumnType;
Expand Down Expand Up @@ -133,10 +135,29 @@ export class DataDefinitionBuilder extends StatementBuilder {
this.columnDefaultFalse();
}
else if (isExpressionToken(column.default)) {
// CURRENT_TIMESTAMP does not work when wrapped in parenthesis for
// default value; but all other expressions should be wrapped
let wrapParens = true;

if (
isDatabaseFunction(<any>column.default) &&
(column.default as DatabaseFunctionToken).fn ===
DatabaseFunctionKeys.CURRENT_TIMESTAMP
) {
wrapParens = false;
}
else {
this.sql.openParens();
}

const dml = this.getQueryBuilder();
dml.expression(<Expression>column.default);

this.appendBuilder(dml);

if (wrapParens) {
this.sql.closeParens();
}
}
else {
this.sql.append(column.default + ' ');
Expand Down