Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 0.2 #102

Closed
2 tasks
skalee opened this issue Aug 18, 2018 · 3 comments
Closed
2 tasks

Release 0.2 #102

skalee opened this issue Aug 18, 2018 · 3 comments

Comments

@skalee
Copy link
Contributor

skalee commented Aug 18, 2018

  • Do a version bump to 0.2
  • Push it to RubyGems

Currently, the only known bug is #101. We always specify "pgp-sha1" as "micalg" parameter for "multipart/signed" MIME type, disregarding what digest algorithm we actually use during signature calculation. Both RNP and GPGME adapters are affected, and in the latter case fixing it may be non-trivial.

This bug does not break signature in any way, however it makes one-pass verification impossible. Nevertheless, mail-gpg gem does exactly the same…

I am fixing it now, but perhaps it is not critical, and we can make a release.

cc @ronaldtse @ribose-jeffreylau
@skalee
Copy link
Contributor Author

skalee commented Mar 20, 2019 •
edited
Loading

@ronaldtse Could you add me to https://rubygems.org/gems/enmail, so I can make releases, please?

@ronaldtse
Copy link
Contributor

@skalee done!

@skalee
Copy link
Contributor Author

skalee commented Mar 20, 2019

Thanks! Version 0.2 has been released.

@skalee skalee closed this as completed Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ronaldtse @skalee