Return actual hash algorithm from GPGME adapter #110
Conversation
skalee
force-pushed
the
micalg-in-gpgme
branch
from
b824f5a to
6dfc483
Compare
|
Thanks @skalee ! |
skalee
force-pushed
the
micalg-in-gpgme
branch
from
6dfc483 to
8ed576f
Compare
|
I got no idea why CodeCov reports are so negative. Perhaps re-running that will change something. |
|
@skalee happy to have it merged as long as it works. CodeCov is not always accurate anyway. |
Whilst less convenient, it allows for greater control, which will be required soon for obtaining the hash algorithm.
Determine actual hash algorithm used for signature computation, and return it from #compute_signature defined in GPGME adapter.
skalee
force-pushed
the
micalg-in-gpgme
branch
from
8ed576f to
7df19e0
Compare
Codecov Report
@@ Coverage Diff @@
## master #110 +/- ##
==========================================
- Coverage 99.92% 99.76% -0.16%
==========================================
Files 37 37
Lines 1253 1273 +20
==========================================
+ Hits 1252 1270 +18
- Misses 1 3 +2
Continue to review full report at Codecov.
|
|
CodeCov is accurate here. I've switched from high-level API to mid-level one by copy-pasting few of code from gpgme gem. The untested part is two lines in exception handling, and because this pull request is concentrated on just few methods, this is enough to impact codecov/patch report drastically. A slight drop in overall coverage is also a fact. Nevertheless, this is not critical. I'll add a comment and merge. |
|
Got it. Thanks @skalee ! |
Fixes #107. Algorithm preference should be set in a
gpg.conffile.