Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add interface for wiki increments #110

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/ribose.rb
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
require "ribose/profile"
require "ribose/wiki"
require "ribose/member_role"
require "ribose/wiki_increment"

module Ribose
def self.root
Expand Down
33 changes: 33 additions & 0 deletions lib/ribose/wiki_increment.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
module Ribose
class WikiIncrement < Ribose::Base
include Ribose::Actions::Create

# Create wiki increments
#
# @param space_id [String] The space UUID
# @param wiki_id [String] The wiki page UUID
# @param optinons [Hash] Query parametars as Hash
# @return [Sawyer::Resources] New wiki increment
#
def self.create(space_id:, wiki_id:, **attributes)
new(space_id: space_id, wiki_id: wiki_id, **attributes).create
end

private

attr_reader :space_id, :wiki_id

def resource
"increment"
end

def extract_local_attributes
@wiki_id = attributes.delete(:wiki_id)
@space_id = attributes.delete(:space_id)
end

def resources_path
["spaces", space_id, "wiki/wiki_pages", wiki_id, "increments"].join("/")
end
end
end
29 changes: 29 additions & 0 deletions spec/ribose/wiki_increment_spec.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
require "spec_helper"

RSpec.describe Ribose::WikiIncrement do
describe ".create" do
it "creates a new wiki page increment" do
wiki_id = 789_123_567
space_id = 123_456_789

increment = Ribose::WikiIncrement.create(

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Useless assignment to variable - increment.

wiki_id: wiki_id, space_id: space_id, **increment_attrs

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put a comma after the last parameter of a multiline method call.

)
end
end
# describe ".all" do
# it "retrieves the list of wiki increments" do
# wiki_id = 789_123_567
# space_id = 123_456_789
#
# increments = Ribose::WikiIncrement.all(space_id, wiki_id)
# end
# end
#
def increment_attrs
{
revision: 0,
delta: { ops: [{ insert: "a" }] },
}
end
end