fix race condition in Reader due to concurrent map write #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jonathaningram
commented
Nov 20, 2023
jonathaningram
commented
```
fatal error: concurrent map writes
github.com/richardlehane/msoleps.addDefaults(...)
/go/pkg/mod/github.com/richardlehane/msoleps@v1.0.3/sets.go:20
github.com/richardlehane/msoleps.(*Reader).start(0xc001bb1f78, {0xc8a180?, 0xc00037be80?})
/go/pkg/mod/github.com/richardlehane/msoleps@v1.0.3/msoleps.go:125 +0x2de
github.com/richardlehane/msoleps.(*Reader).Reset(...)
/go/pkg/mod/github.com/richardlehane/msoleps@v1.0.3/msoleps.go:76
...
```
jonathaningram
added a commit
to sajari/docconv
that referenced
this pull request
Nov 20, 2023
See [my race fix PR]. Saw the issue in our logs, so using our fork for now. [my race fix PR]: richardlehane/msoleps#6
jonathaningram
added a commit
to sajari/docconv
that referenced
this pull request
Nov 20, 2023
See [my race fix PR]. Saw the issue in our logs, so using our fork for now. [my race fix PR]: richardlehane/msoleps#6
|
thanks very much for this contribution @jonathaningram |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.