Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EventHubs migration guide (start) #2

Closed
wants to merge 37 commits into from
Closed

EventHubs migration guide (start) #2

wants to merge 37 commits into from

Conversation

richardpark-msft
Copy link
Owner

No description provided.

@richardpark-msft richardpark-msft force-pushed the richardpark-eh-migration-guide branch from 0b2df58 to 29858fe Compare December 4, 2019 23:52
@richardpark-msft richardpark-msft changed the title Richardpark eh migration guide EventHubs migration guide (start) Dec 4, 2019
@richardpark-msft @chradek
Update event hubs migration guide.md
45065e3 
Co-Authored-By: chradek <51000525+chradek@users.noreply.github.com>
ramya-rao-a
ramya-rao-a reviewed Dec 5, 2019
View reviewed changes
Copy link

@ramya-rao-a ramya-rao-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start!

I have left a few comments, please take a look

event hubs migration guide.md Outdated Show resolved Hide resolved
event hubs migration guide.md Outdated Show resolved Hide resolved
event hubs migration guide.md Outdated
|---------------------------------------------|------------------------------------------------------------------|--------|
| `EventHubClient.createFromConnectionString` | `new EventHubProducerClient()` or `new EventHubConsumerClient()` | [All](https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/eventhub/event-hubs/samples/)
| `EventHubClient.receive` | `EventHubConsumerClient.subscribe` | [receiveEvents](https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/eventhub/event-hubs/samples/receiveEvents.ts) |
| `EventHubClient.receiveBatch` | Removed in favor of `EventHubConsumerClient.subscribe` | [receiveEvents](https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/eventhub/event-hubs/samples/receiveEvents.ts) |
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed in favor of EventHubConsumerClient.subscribe which now supports batching. Default size is 10 which you can change using the option maxBatchSize

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only reason I didn't add this text was because it crowds the cell a bit and the sample does clearly show how to use it (with batching).

Just trying to make the table work as an "at a glance" thing.

event hubs migration guide.md Outdated Show resolved Hide resolved
event hubs migration guide.md Outdated Show resolved Hide resolved
event hubs migration guide.md Outdated Show resolved Hide resolved
event hubs migration guide.md Outdated Show resolved Hide resolved
event hubs migration guide.md Outdated Show resolved Hide resolved
event hubs migration guide.md Outdated Show resolved Hide resolved
event hubs migration guide.md Outdated Show resolved Hide resolved
richardpark-msft and others added 5 commits December 6, 2019 11:14
@richardpark-msft
Updating migration guide sample for sending.
8edaf44
@richardpark-msft
Add in a description of EventProcessorHost
52bce99
@richardpark-msft
Removed the 'as well'
79fdac1
@mikeharder
Unlink dependencies if tests fail (Azure#6483)
a46af7a 
- Results are published for both success and failure
- Unlink dependencies should use the same condition as publish
- Continuation of Azure#6418
@jeremymeng
[Storage] Add more tests covering progress events (Azure#6428)
1ff3be6 
* [Storage] Add more tests covering progress event

Related to Azure#6352.
jsquire
jsquire reviewed Dec 10, 2019
View reviewed changes
event hubs migration guide.md Outdated Show resolved Hide resolved
event hubs migration guide.md Outdated Show resolved Hide resolved
event hubs migration guide.md Outdated Show resolved Hide resolved
richardpark-msft and others added 2 commits December 10, 2019 08:23
@richardpark-msft
[event-hubs] Better error handling and reporting (Azure#6465)
3a81099 
Prior to this change we couldn't tell the difference between "storage is failing for some reason" and "we're just losing to other processors that are attempting to claim partitions".

Now an empty list of ownerships is okay and just indicates that we should do nothing this time around.

Fixes Azure#6444 minus the the change to exit the processing loop.
@jeremymeng
[Core-http] Move getDefaultProxySettings into proxyPolicy (Azure#6478)
94b5d23 
* [Core-http] Move getDefaultProxySettings into proxyPolicy

so that libraries that don't use the PipelineOptions or createDefaultRequestPolicyFactories from core-http can use this behavior without duplicating code.
@jsquire jsquire mentioned this pull request Dec 10, 2019
Closed
chradek and others added 4 commits December 10, 2019 13:35
@chradek
[core-amqp] adds support for idle timeout and additional logging (Azu…
27d9cb1 
…re#6492)

* [core-amqp] adds logging around dns.resolve in checkNetworkConnection

* [core-amqp] adds support for idle timeout check

* updates pnpm lock file
@richardpark-msft
[event-hubs] Updating samples folder to make it a standalone project (A…
887e83a 
…zure#6413)

Updating samples folder to make it a standalone project

* Makes it simpler for users to just download the entire folder, npm install and run.
* Makes it more effective for us as a testing tool since we can use it to test whatever is published.
@richardpark-msft
Adding example for EventProcessorHost => EventHubConsumerClient migra…
39f6a44 
…tion
@richardpark-msft
* Don't use $Default anywhere if we can avoid it. Guide the user choo…
339ba8c 
…se a consumer group name.

* Give the document a bit more structure, including a TOC for the inline migration samples.
richardpark-msft and others added 2 commits December 10, 2019 16:46
@richardpark-msft @ramya-rao-a
Document the multiple types of message receiving we can handle.
20492ab 
Co-Authored-By: Ramya Rao <ramya.rao.a@outlook.com>
@richardpark-msft @ramya-rao-a
We only construct clients, not empires.
78138d4 
Co-Authored-By: Ramya Rao <ramya.rao.a@outlook.com>
@richardpark-msft @ramya-rao-a
It's a function. Be proud of it and call it theoretically in the table.
8992aee 
Co-Authored-By: Ramya Rao <ramya.rao.a@outlook.com>
@richardpark-msft @ramya-rao-a
Parens.
58bdcb1 
Co-Authored-By: Ramya Rao <ramya.rao.a@outlook.com>
richardpark-msft and others added 2 commits December 10, 2019 16:49
@richardpark-msft @ramya-rao-a
Removed!
07fb17c 
Co-Authored-By: Ramya Rao <ramya.rao.a@outlook.com>
Updated with in-person feedback
b6286da
richardpark-msft and others added 8 commits December 10, 2019 17:08
@richardpark-msft @ramya-rao-a
The user is in control of the batch size...
de034b9 
Co-Authored-By: Ramya Rao <ramya.rao.a@outlook.com>
Merge branch 'richardpark-eh-migration-guide' of https://github.com/r…
93e8259 
…ichardpark-msft/azure-sdk-for-js into richardpark-eh-migration-guide
@richardpark-msft @ramya-rao-a
Let's assume they're already full events and not just data.
8e74f24 
Co-Authored-By: Ramya Rao <ramya.rao.a@outlook.com>
Tenatitively fixing sample
bb92f68
Merge branch 'richardpark-eh-migration-guide' of https://github.com/r…
9b37716 
…ichardpark-msft/azure-sdk-for-js into richardpark-eh-migration-guide
Merge remote-tracking branch 'upstream/master' into richardpark-eh-mi…
2c25e0e 
…gration-guide
@richardpark-msft @ramya-rao-a
Advertise the goodness that was EPH and that is now part of the Event…
96d7a5b 
…HubConsumerClient

Co-Authored-By: Ramya Rao <ramya.rao.a@outlook.com>
@richardpark-msft
* Make sample a bit more interesting by allowing them to specify the …
0db9b43 
…max batch size.

* Added in some more console output to better illustrate the control flow.
* Move migration guide to its final location.
@ramya-rao-a
Copy link

The work here is being continued in Azure#6501

richardpark-msft added a commit that referenced this pull request Mar 11, 2021
@richardpark-msft
Step #2 - making fairly straightforward changes to everyone's package…
834fb3e 
….json

Everyone:
- Update to opentelemetry/api@0.18
- Change everyone's devDependency to sync with the version currently in master (which is a preview)
- Point to the latest core-tracing package (1.0.0-preview.11)

NOTE: Packages that referenced \@azure/storage-blob needed to reference the current version in master (which is a preview). This should be a temporary issue, but the current state of opentelemetry makes it difficult for us to do a partial migration.

This affects:
* storage-blob-changefeed
* storage-file-datalake
* perf-tests/storage-blob
* quantum-jobs
richardpark-msft pushed a commit that referenced this pull request Feb 17, 2023
@andykao1213 @dubiety @alankashiwa
[Maps] Onboarding @azure-rest/maps-route (Azure#23588)
ad48f52 
* Update maps dependency in pnpm-lock.yaml

* Fix sample metadata errors

* Fix linting errors

* Fix linting errors

* Fix run time error

* Update package.json in samples folder

* Fix linting errors

* Fix linting errors

* Add changelog for maps-common

* Update recording files for maps-search

* Add test.yml for maps-search

* Add tests.yml for render and route

* Update tests.yml

* Update test-resources.json for maps

* Fix tests.yml format error

* Update env vars and remove unused export var

* Remove unused code

* Fix lock file

* Remove route & render

* Replace `beginGet*Batch` with `resume*Batch`

We provide a `beginGet*Batch` method to resume the previous
request previously. This is not ideal because it need to get a
`batchId` which is store in the internal state of the LRO. Once
the LRO brings changes, our code will be broken.

We can achieve the same thing by using serialized state.
This change aims to leverage this approach and create convenience
methods `resume*Batch` for users

* Update recording

* Make the endpoint of `MapsSearchClient` configurable

* Change LatLon from an interface to a tuple

Also remove the `toLatLon` function since creating a tuple
is quite easy.

* Make the props `coordinates` and `countryCodeFilter` optional

Specifying `coordinates` and `countryCodeFilter` can narrow the results
of the fuzzy search. But considring the case like searching "Australia",
theese fields may have no use. We decided to make them optional so user
can decides if they want to narrow down the results or not.

* fixup! Remove route & render

* Adjust CHANGELOGs of maps-search & common

Following the keyvault-common, removing CHANGELOGs
from maps-common since it's not published.

* Update samples

* Add batchRequest sample

* Add a new sample searchAddressResult

* Update search.ts and its examples

* enhance code example in README.md

* comment unused import

* Update recording for maps-search

* remove redundant recording files

* Add maps-search

* Rename LatLong to LatLon

* Fix constructor Readme doc

* Update readme to new signature

* Add tests partially

* Change LatLon/BoundingBox to interfaces

* Reduce the number of constructor overloading

* Rename SearchClient as MapsSearchClient

* Add options mapper tests

* Add result type mapper tests (in progress)

* rename clientId to mapsAccountClientId

* listPolygons -> getPolygons

* getPointOfInterestCategoryTree -> getPointOfInterestCategories

* Expose missing model

* Add alternative input file for quick experiment

* Regenerate code and make changes accordingly

* Reduce number of overloads of fuzzy searches

* Add geojson types

* Adopting new geojson definitions

* Change test specs to align with new method names

* clean up models and tsconfig

* Expose Known* models

* Remove batch sync methods

* Add public tests (non-batch)

* move model

* Add docstrings

* Start polling in begin* method

* Refactor BatchPoller for retrieving batchId

* Finalize batch pollers

* Readd batch methods

* Update generated code

* Finalize batch signature

* Rebuild samples & clean up

* Add AAD tests

* Clean up Swagger readme

* Fix spelling

* Add initial files for @azure/maps-route module

* maps-search: change comments and perform formatting

* Methods options and testing skeleton for maps-route

* maps-search: refactor options

* Improve convenience layer for non-LRO methods

* Change variable names

* Complete batch methods

* update maps-search Readme

* Update maps-route Readme

* Add generated samples for maps-route

* Update samples for maps-search

* Delete backup file

* Add maps-common module

* Update maps-route/maps-search to use maps-common

* maps-render: first draft

* Use LatLon/BoundingBox from maps-common

* Complete maps-render with tests

* Expose required types from maps-route

* Expose required types from maps-search

* Complete unit tests for maps-render

* Update maps-render README

* Update samples

* Fix comment/strings

* Fix comment/strings

* Update Route comment/interface

* Regenerate code

* Update files

* Define required fields and fix code

* Remove non-poller batch methods

* Fix playback test failure

* Rename parts of model names

* Rename remaining parts of models according to review feedback

* Remove TODO comments

* Update Reamdme transform to reflect latest swagger

* Change key policy name

* Simplify batch item error model

* Add brower tests

* Turn maps-common into internal module

* Rearrange Readme

* Rewrite Readme for common

* Remove batch-sync methods

* Route required fields: part 1

* Route required fields: part 2

* Add AAD back

* Route model fixes #1

* Route model fixes #2 + geojson named tuples

* Refine geojson types

* Aliased a few method options

* maps-render required fields part 1

* Do not validate budget parameters

* Revert "Do not validate budget parameters"

This reverts commit 4ec3f5f.

* Rename MapTileset to TileJson

* Render: model rename & type improvement

* Explicitly transform image range

* Fix route record tests

* Update map account creation commands in Readme

* Update Readme/docstrings/samples for Search/Route/Render

* Remove rollup and use dev-tool instead

* Remove some empty tests

* Add AAD test case and make file name shorter

* Update test cases

* Update cspell rules

* Update recording files

* Simplify test cases

* Sync cspell.json from upstream

* Use test-recorder 2.0 and update unit test cases

* Push wrong browsers recording files

* Update settings to support recording

* Fix dependency errors

* Upgrade api-recorder and fix errors

* Code refinement

* Update maps search recording files

* Update karma.conf.js format

* Update recording files and settings

* Fix broken links

* Update maps dependency in pnpm-lock.yaml

* Fix sample metadata errors

* Fix linting errors

* Fix linting errors

* Fix run time error

* Update package.json in samples folder

* Fix linting errors

* Fix linting errors

* Add changelog for maps-common

* Update recording files for maps-search

* Add test.yml for maps-search

* Add tests.yml for render and route

* Update tests.yml

* Update test-resources.json for maps

* Fix tests.yml format error

* Update env vars and remove unused export var

* Remove unused code

* Fix lock file

* Remove maps-render

* fixup! Change LatLon from an interface to a tuple

* Comment the future doc link

* Update doc & fix type issue

* fix lint issues

* Regenerate API View

* Comment the whole [apiref] since the original syntax cannot pass the Analyze/Link verification

* Fix issue related to the change of maps-common

- Replace beginGet*Result with resume* methods
- Turn LatLon to a tuple
- Add mapper to transform the string to Date because resume* method will
return a serialized Date

* Update test recording

* Remove maps-common from the Artifacts

* remove unused dependencies

* Add impression in README so we can track the page views

* Remove `AZURE_LOG_LEVEL` in test.yml

* Update samples

- Move the option parameter to the right place
- Add comments & "break" for handling the type of the search result to make it clear for the user

* Patch {} to properties for GeoJsonPolygon

* rename maxDetourTime to maxDetourTimeInSeconds

* Update recordings

* Remove any

* Rename to detourTimeInSeconds to align the convention

* Change the test.yml EnvVar

See more explanation here:
- Azure#23039 (comment)
- Azure#23039 (comment)

* Rename numResults to numberResults

* Add document comment

* Add endpoint options to MapsRouteClient

* Remove unused dependencies in maps-route

* fixup! Change the test.yml EnvVar

* Update interfaces & documents

* Update changelog

* Merge getRouteDirection with the additional parameter one

* Update samples

* Make the `maps-common to a published package

* Update the import of `maps-common` in `maps-search`

* Fix CI Issue

* Add documents for geojson

* Update the samples & readme

* Leverage maps-common package in mpas-route

* chore update

- Remove the unnecessary rule setting of eslint
- Update the legacy type path

* Remove unnecessary eslint config

* WIP: Remove LRO generation

* WIP: refactor mapsRouteClient

* WIP: first generation

* Format the generated code

* Support AAD

* Transform the model name

* Add helper functions

* Add a sample - route.ts

* Add samples for lro

* Add test

* Generate samples

* Add api view

* Update the generation

* WIP: ReadMe

* Rename "computeBestOrder" to "computeBestWaypointOrder"

* Refine README

* Rename model

* Add test createRouteDirectionsBatchRequest

* Fix lint issue

* Add missing metadata

* Remove maps-route/

* Update CI issue

* Fix merged issue

* Update version rule for maps-common

* Update CI name

* Remove extra lint config

* Use `require` in the README for consistency

* Regenerate the samples

* Remove redundant recording files

* Remove unused parameters in test-resources.json

* Refine readme snippet

* Log something specific for the result

* Update samples

* Split the route.ts into 3

* Remove model rename

* Use default export for RLC factory function

Co-authored-by: Charlie Chen <charlie.chen@microsoft.com>
Co-authored-by: Charlie Chen <yuchungchen@microsoft.com>
Co-authored-by: --global <alankashiwa@gmail.com>
richardpark-msft pushed a commit that referenced this pull request Feb 17, 2023
@mrinal2601 @deyaaeldeen
Load testing GA RLC #2 (Azure#24563)
7923e2d 
* initial changes stableversion

* old files modified

* Added polling Helper

* Added initial sample and tests

* Added API Review

* Added samples for JS and TS

* pnpm lock file and Readme Update

* Added test and removed locale from readme

* Corrected broken links

* Added dev-tool and eslint

* formatting changes

* Added Browser Recordings

* Code generated from main API

* Added Test Recordings

* Added Samples for JS and TS

* Added Validation Poller

* added champion scenario in single file

* added stop and delete samples

* Update sdk/loadtestservice/load-testing-rest/package.json

Co-authored-by: Deyaaeldeen Almahallawi <dealmaha@microsoft.com>

* added TestRun LRO

* modified upload and validte LRO

* Single Test File for test and testrun

* Samples and LRO changes

* Create Test in LRO removed from sample

* Update sdk/loadtestservice/load-testing-rest/src/beginCreateOrUpdateTestRun.ts

Co-authored-by: Deyaaeldeen Almahallawi <dealmaha@microsoft.com>

* Update sdk/loadtestservice/load-testing-rest/src/beginUploadTestFile.ts

Co-authored-by: Deyaaeldeen Almahallawi <dealmaha@microsoft.com>

* Samples and LRO changes as per review

* Added timeout in samples and test recordings

* New Samples generated and corrected broken link

* Update sdk/loadtestservice/load-testing-rest/samples-dev/stopTest.ts

Co-authored-by: Deyaaeldeen Almahallawi <dealmaha@microsoft.com>

* Update sdk/loadtestservice/load-testing-rest/samples-dev/stopTest.ts

Co-authored-by: Deyaaeldeen Almahallawi <dealmaha@microsoft.com>

* Update sdk/loadtestservice/load-testing-rest/src/beginUploadTestFile.ts

Co-authored-by: Deyaaeldeen Almahallawi <dealmaha@microsoft.com>

* Added Sleep Utility

* Updated Readme

* Updated Changelog

* Updated LRO to take queryparams

* Added Tests for LRO impl

* Generated latest Samples

* GetLROHelper Similar impl

* Review Comment Changes

* Updated imports

* LRO error condtions corrected

* Added AbortSignal Changes

* Added LRO Tests

* Removed Begin Methods and added new recordings for tests

* Corrected Broken Links

* rush file update

* build failure due to core-http formatting

* LRO Helper Changes Done

* Ran API extractor again

* Running empty tests

* Review Comments LRO Helper

* New API review

* LRO helper refactoring

* Updated Samples and Readme

* Throw Error when Abort

* Updated Sample

* Updated API View

* Updated package.json, Readme and Samples

* Updated Release date and core-client version

Co-authored-by: Deyaaeldeen Almahallawi <dealmaha@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chradek chradek chradek left review comments

@ramya-rao-a ramya-rao-a ramya-rao-a left review comments

@jsquire jsquire jsquire left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@richardpark-msft @ramya-rao-a @jsquire @chradek @mikeharder @jeremymeng