Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trim leading and trailing newlines #91

Merged
merged 3 commits into from
Nov 3, 2024
Merged

Trim leading and trailing newlines #91

merged 3 commits into from
Nov 3, 2024

Conversation

mataha
Copy link
Contributor

@mataha mataha commented Feb 12, 2024

This is a follow-up to #85 - while newlines inserted as a result of inlining assets within the plugin were rid of, trailing EOF whitespace characters within the inlined code persist:

<!doctype html>
<html>
  <head>
    <style>html{box-sizing:border-box;text-size-adjust:none}
</style>
  </head>
  <body>
    Hello World!
  </body>
</html>

(I had to split this PR in order to build the project on Windows without any errors - d4ca753 is the main course, 214fd1b consists of changes to the project itself)

@mataha mataha mentioned this pull request Feb 12, 2024
Closed
@richardtallent richardtallent merged commit 4febbc0 into richardtallent:main Nov 3, 2024
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardtallent richardtallent richardtallent approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mataha @richardtallent