This repository has been archived by the owner on Jul 27, 2023. It is now read-only.
HH-157725 add path and responseCode parameters to ClientEventCallback interface methods #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… interface methods
Tipnik
reviewed
Sep 29, 2022
| /** | ||
| * @deprecated use {@link #onHttpRequestSuccess(String, String, String, String, int)} instead. | ||
| */ | ||
| @Deprecated(forRemoval = true) |
There was a problem hiding this comment.
Is is ok to use Java 9 style @deprecated in this project?
There was a problem hiding this comment.
Deleted forRemoval attribute
| public void httpRequestSuccess(Request request, Response<?> response) { | ||
| EVENT_EXECUTOR.submit(() -> { | ||
| callback.onHttpRequestSuccess(clientName, request.method(), request.url().query()); | ||
| callback.onHttpRequestSuccess(clientName, request.method(), request.url().encodedPath(), request.url().query(), response.code()); |
There was a problem hiding this comment.
I wonder, is it good to have both callbacks executed?
Maybe it would be better to call the old deprecated method in new default one:
default void onHttpRequestSuccess(String clientName, String method, String path, String queryString, int responseCode) {
// Kept for compatibility at the moment
onHttpRequestSuccess(clientName, method, queryString);
}
Then replacing calls here would still keep the backwards compatibility?
There was a problem hiding this comment.
Yes, it's good idea, thank you!
…ds for backwards compatibility
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
We overloaded ClientEventCallback interface methods to be able to path some additional information (path and responseCode) to implementation. This information can be useful for example for monitoring.