Allow Users to Run Multiple Scripts #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricoberger
force-pushed
the
run-multiple-scripts
branch
2 times, most recently
from
97c8444
to
0753bfc
Compare
Until now it was only possible to run a single script within one Prometheus job, because the `script` parameter could only be provided one time. With the changes in this commit it is now possible to run multiple scripts within one Prometheus job, for that the `script` parameter can be specified multiple times. For each specified script we are running the same logic as for a single script and then we merge the output of each script execution into one result. Limitations: - The specified parameters are used for all scripts, it is not possible to specifiy different parameters for the scripts. - The timeout specified via the `X-Prometheus-Scrape-Timeout-Seconds` might not work correctly, if the offset is not large enough, since the timout logic is applied for all scripts. - If there is an error in the logic for one script, e.g. one of the defined scripts can not be found, the other scripts will also return not output.
ricoberger
force-pushed
the
run-multiple-scripts
branch
from
0753bfc
to
e15129b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now it was only possible to run a single script within one Prometheus job, because the
scriptparameter could only be provided one time.With the changes in this commit it is now possible to run multiple scripts within one Prometheus job, for that the
scriptparameter can be specified multiple times. For each specified script we are running the same logic as for a single script and then we merge the output of each script execution into one result.Limitations:
X-Prometheus-Scrape-Timeout-Secondsmight not work correctly, if the offset is not large enough, since the timout logic is applied for all scripts.Closes #100