[chart] Fix condition for enabling selfServiceMonitor

[AlexLov]

I believe selfServiceMonitor shouldn't be enabled until serviceMonitor is also enabled. Otherwise it's better to move its configuration to separate/independent section and disable by default same way as serviceMonitor.

Otherwise I got the error:

no matches for kind "ServiceMonitor" in version "monitoring.coreos.com/v1" ensure CRDs are installed first

This is because I don't use it and thus didn't install this CRD at all but chart worked for me but failed when I tried to upgrade it from 0.6.2 to 0.8.3.

[ricoberger]

Hi @AlexLov and thanks for your contribution 🙂.

The .Values.serviceMonitor.enabled is used to create the ServiceMonitors for the scripts defined in the config file. So I think it would make more sense to change the default value for .Values.serviceMonitor.selfMonitor.enabled to false to work around the problem.

I'm with you that it makes more sense to move it to it's own section in this case, but looking at other Helm charts (e.g. the blackbox-exporter) it looks like they are handling this very similar:

• The ServiceMonitor for the exporter metrics https://github.com/prometheus-community/helm-charts/blob/b6adaa109f4c27db3a4a9465c84c0d50f28aec78/charts/prometheus-blackbox-exporter/templates/selfservicemonitor.yaml
• The ServiceMonitor for the target https://github.com/prometheus-community/helm-charts/blob/b6adaa109f4c27db3a4a9465c84c0d50f28aec78/charts/prometheus-blackbox-exporter/templates/servicemonitor.yaml

So I think I would prefer to just change the default value to false for now. Can you adjust you PR accordingly please and also bump the Helm chart version in Chart.yaml file.

[AlexLov]

Hey @ricoberger
Done

[ricoberger]

Thanks again for your contribution 🙂