Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config check): add the commandline argument '--config.check', to… #96

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

wat-org
Copy link

@wat-org wat-org commented Oct 16, 2023

hello,

This MR add the command line option config.check to validate the configuration file only.

This aslo fixes the content of the README file, and remove a useless log.

Regards

Copy link
Owner

@ricoberger ricoberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @wat-org, thanks for your contribution 🙂. I added two small comments everything else is looking good.

pkg/exporter/metrics.go Outdated Show resolved Hide resolved
charts/script-exporter/Chart.yaml Outdated Show resolved Hide resolved
@wat-org
Copy link
Author

wat-org commented Oct 17, 2023

hello @ricoberger

Thanks for your quick answer.

It's done (commit amend/push force).

I've resolved the 2 threads too (not sure it was on my side...)

@ricoberger
Copy link
Owner

Awesome, thank you 🙂

@ricoberger ricoberger merged commit cd87065 into ricoberger:main Oct 17, 2023
1 check passed
@wat-org
Copy link
Author

wat-org commented Oct 17, 2023

too fast !

thanks to you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants