Include missing CTest module #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the libdivide project's
CMakeLists.txtfile sets up tests in a way that makes it possible to run the tests from the build directory by executing thectestcommand. Yet theCMakeLists.txtfile does not include the CTest CMake module anywhere. This pull request includes the CTest module in the appropriate location.I'm actually surprised executing the
ctestcommand to run libdivide's tests even worked without including the CTest module in the first place. Maybe one of the other included CMake modules ended up transitively loading the CTest module. This, however, would be undocumented behaviour (AFAIK) that should not be relied on.