Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement 16-bit SSE2 & AVX2 vector division #94

Merged
merged 2 commits into from
Feb 12, 2022

Conversation

adbancroft
Copy link
Collaborator

The current implementation is a workaround: this PR uses the appropriate vector operations to implement 16-bit division for __m256i & __m128i

ridiculousfish added a commit that referenced this pull request Feb 12, 2022
This reverts commit 5731cec.

This allows #94 to be mergeable again
Copy link
Owner

@ridiculousfish ridiculousfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM, thank you!

@adbancroft adbancroft merged commit 1978f27 into ridiculousfish:master Feb 12, 2022
@adbancroft adbancroft deleted the 16bit_avx256_avx128 branch February 12, 2022 14:26
@ridiculousfish
Copy link
Owner

Huh?

azat added a commit to azat/ClickHouse that referenced this pull request Dec 13, 2022
This will includes at least [1].

  [1]: ridiculousfish/libdivide#94

v2: Define LIBDIVIDE_* macros mutually exclusive
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants