Use matrix definitions from pyquil.gate_matrices. Issues #99 and #16 #103
Conversation
There was a problem hiding this comment.
I have one comment which you can implement or ignore. It is about possibly reinstating the amplitude_damping in the Kraus representation.
I found some more places where you can use these definitions eg. in test_distance_measures the functions test_diamond_norm, test_watrous_bounds, test_process_fidelity can use this treatment. I made the changes feel free to revert them and do it a different way.
Otherwise it looks good.
| from pyquil import Program | ||
| from pyquil import gate_matrices as mat | ||
| from pyquil.api import QVM | ||
| from pyquil.gates import CNOT, X | ||
| from pyquil.gate_matrices import X as X_MAT, Y, Z |
There was a problem hiding this comment.
Interesting. I had not thought about this problem i.e.
from pyquil.gates import CNOT, X
from pyquil.gate_matrices import X as X_MAT, Y, Z
maybe we should standardize around your solution above i.e. the matrix representation is always called G_MAT for some gate G.
| # Test philosophy: | ||
| # Using the by hand calculations found in the docs we check conversion | ||
| # between one qubit channels with one Kraus operator (Hadamard) and two | ||
| # Kraus operators (the amplitude damping channel). Additionally we check | ||
| # a few two qubit channel conversions to get additional confidence. | ||
|
|
||
| # The Amplitude Damping channel (one qubit) |
There was a problem hiding this comment.
Hmm Im in superposition about the removal here. Here are my thoughts.
- pyQuil noise models are in flux now. We don't know what will happen.
- this is self contained within forest.benchmarking so keeping it makes it easy to check with conventions in the markdown file.
- the name relaxation does not match what we have in the docs and the rest of the code.
- I get the flip side too. Reducing code duplication etc.
I guess in the end my superposition is slightly biased towards restoring the function but I'll leave it up to you.
Issues #99 and #16