-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add all-in-one wrappers. #182
Conversation
Waiting for #181 to be merged before fixing the notebooks and finalizing things. |
* Begin clean of docs, setup notebook linking. * Ignore superop autogen * Linked examples notebooks to module page for rb, dfe. * Add tomography notebooks and do_tomography. * Add examples and clean up warnings * Clean up classical logic docs. * Add progress bar to adder, include notebook in docs. * Fix compilation errors and typos. * Clean up doc errors in dfe. * Revert accidental template change. * Cleanup dm docstrings. * Clean up operator_tools docs. * Clean up op_est docs. * Finish resolving build warnings. * Notebook spellcheck and format fix. * Resolve last batch of warnings besides notebook interlinks. * Finish cleaning up and evaluating notebooks. * Fill out examples in quick start, shorten header title for obs_est. * Add do methods to docs. * Move examples to docs. * Move examples to docs and tweak the nb links. * Add a link to the examples folder. * Update example nb test link. * Remove reference to nblink
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to read the meaty parts and it looks fine to me.
Do break up the PR into smaller chunks in the future.
@kylegulshen Fix the tests. |
Also, can you rebase this? |
Waiting for tests, then I'll merge if they pass. |
This has a few API / signature changes. The main contribution is to add a
do_x
wrapper that does all three stages of the experiment together with default parameters. The args list and order is standardized for all of these routines, and the args for similar functions was made to match this.closes #178
closes #81