-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use pyquil symmetrization functionality #194
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is much easier to under stand and shorter now that symmetrization is in pyquil.
|
||
for expt_result in expt_results: | ||
# TODO: allow weight > symm_type |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One possibility is to use exhaustive if weight > strength of current sym_type.
Realistically the stabilizers are usually weight 4, for codes people care about. (This suggests, as a separate pyQuil PR, that we might consider trying to find a family of strength 4 OAs.) In general but you might find some use in up to weight 6.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Happy we're deduping. Will approve when tests pass.
Description
We moved and expanded the symmetrization functionality from observable_estimation over to pyquil. This PR makes use of the pyquil functionality. Calibration hasn't yet been made to work with all options of symmetrization. A warning is thrown if the weight of a calibrated observable is greater than the symmetrization strength (symm_type).
Checklist
auto-close keywords.
docs/source/changes.rst
) has a description of this change.