Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add Drop implementations and reclaim CString memory #37

Merged
merged 4 commits into from
Oct 11, 2023
Merged

fix: add Drop implementations and reclaim CString memory #37

merged 4 commits into from
Oct 11, 2023

Conversation

notmgsk
Copy link
Contributor

@notmgsk notmgsk commented Oct 9, 2023

No description provided.

Shadow53
Shadow53 requested changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@Shadow53 Shadow53 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions. The only required one, imo, is not collect()-ing into a Vec when the closure returns unit values./

lib/src/quilc.rs Outdated Show resolved Hide resolved
lib/src/quilc.rs Outdated Show resolved Hide resolved
lib/src/qvm.rs Outdated Show resolved Hide resolved
@notmgsk notmgsk merged commit 1d4bdac into main Oct 11, 2023
@notmgsk notmgsk mentioned this pull request Oct 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shadow53 Shadow53 Shadow53 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@notmgsk @Shadow53