-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump version to 2.7.1 for a patch release #899
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blakejohnson
approved these changes
May 1, 2019
karalekas
commented
May 1, 2019
pyquil/operator_estimation.py
Outdated
|
||
stddev = property(get_stddev, set_stddev) | ||
|
||
def get_raw_stddev(self) -> Union[float, complex]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like I got this return type wrong, should be float
.
ecpeterson
approved these changes
May 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#870 and #896 are the main offenders. This PR also cuts down the running time of the operator estimation unit tests by about a factor of 3, so that they dont add 16 minutes to the build. However, there is chance they could fail now due to undersampling (I did my best to test, but it remains to be seen if my testing was thorough enough). In parallel, I have enabled the qvm- and quilc-related tests in Semaphore (the operator estimation tests fall in this bucket). I need to address #898 before they will start working in GitLab CI.