New: Allow skipping the clap dependency via the cli feature.

[dbanty]

No description provided.

[dbanty]

I actually don't know if the cfg is required here... or what would happen if you tried to build the binary without the feature enabled.

[nilslice]

Good call making this optional.

I actually don't know if the cfg is required here... or what would happen if you tried to build the binary without the feature enabled.

I think we'd want cargo build to fail if the cli feature is disabled, with some way of informing the user of the fix. Now, this would fail, but with a message like "consider adding a 'main' function" or somehting.

We could technically do something like this in main.rs:

#[cfg(not(feature = "cli"))]
compile_error!("the feature 'cli' must be enabled to build the qcs-sdk-qir CLI");

I've tested & pushed up this addition, but feel free to change as you see fit.

[nilslice]

Looks good to me, pending any different ideas/thoughts for the compile_error! usage from @dbanty or @kalzoo

[Shadow53]

FWIW, there is a way to specify that a certain target (e.g. a binary) requires certain features. Maybe that is better here?

[nilslice]

@Shadow53 - good call, & TIL! If you'd like to update the PR, please feel free 👍

[Shadow53]

Updated:

$ cargo build --bin main --no-default-features
error: target `main` in package `qcs-sdk-qir` requires the features: `cli`
Consider enabling them by passing, e.g., `--features="cli"`