Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: test that similar calibrations with different sites are not filtered #268

Merged
merged 2 commits into from
Aug 3, 2023
Merged

chore: test that similar calibrations with different sites are not filtered #268

merged 2 commits into from
Aug 3, 2023

Conversation

MarquessV
Copy link
Contributor

@MarquessV MarquessV commented Jul 28, 2023 •
edited
Loading

closes #192

@MarquessV MarquessV linked an issue Jul 28, 2023 that may be closed by this pull request
Add test cases for calibration filtering #192
Closed
@MarquessV MarquessV closed this Jul 28, 2023
@MarquessV MarquessV reopened this Jul 28, 2023
@MarquessV MarquessV marked this pull request as ready for review July 28, 2023 15:33
kalzoo
kalzoo approved these changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@kalzoo kalzoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prefix says wip but offline you said this was ready; lgtm, just needs the right commit syntax. Good thing to bring forward from pyQuil v3.

@MarquessV MarquessV changed the title wip: test that similar calibrations with different sites are not de-duplicated chore: test that similar calibrations with different sites are not filtered Aug 3, 2023
@MarquessV MarquessV merged commit 0c6dd84 into main Aug 3, 2023
@MarquessV MarquessV deleted the 192-add-test-cases-for-calibration-filtering branch August 3, 2023 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalzoo kalzoo kalzoo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add test cases for calibration filtering
2 participants
@MarquessV @kalzoo