Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Don't automatically publish wheels for pre-releases, disable 32-bit windows wheels. #292

Merged
merged 2 commits into from
Oct 31, 2023

Conversation

MarquessV
Copy link
Contributor

@MarquessV MarquessV commented Sep 29, 2023

This stops wheels from publishing on pre-releases automatically. A pre-release will still always be created on merge to main, but only a sdist will be published to PyPI. The Publish workflow can be triggered manually with the publishWheels option if we decide we want to create wheels for a particular pre-release.

I validated these changes as best as I could with nektos/act:

A new pre-release being published only results in a sdist being published

act release -n -e .github/test_events/python_prerelease.json -W .github/workflows/release-python.yml

A manual run by default only publishes a sdist

act workflow_dispatch -n -W .github/workflows/release-python.yml

A full release being published results in a sdist and wheels being published

act release -n -e .github/test_events/python_release.json -W .github/workflows/release-python.yml

A manual run with publishWheels set to true publishes a sdist and wheels

act workflow_dispatch -n --input publishWheels=true -W .github/workflows/release-python.yml

@MarquessV MarquessV marked this pull request as ready for review September 29, 2023 19:20
@MarquessV MarquessV changed the title ci: Don't automatically publish wheels for pre-releases ci: Don't automatically publish wheels for pre-releases, disable 32-bit windows wheels. Sep 29, 2023
.github/test_events/README.md Show resolved Hide resolved
.github/workflows/publish-quil-py.yml Show resolved Hide resolved
@MarquessV MarquessV merged commit 04f38e7 into main Oct 31, 2023
8 checks passed
@MarquessV MarquessV deleted the 291-ci-improvements branch October 31, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants