feat: add waveform templates #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
MarquessV
reviewed
Apr 29, 2024
|
Added visual snapshots to help understand template behavior: |
kalzoo
force-pushed
the
365-waveform-templates
branch
2 times, most recently
from
d2682a9 to
62ac657
Compare
kalzoo
force-pushed
the
365-waveform-templates
branch
from
62ac657 to
a8bbee4
Compare
MarquessV
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds waveform templates described by the Quil spec. (Section 12.2).
This moves out internal/closed-source code into the open source arena to help users better understand how their programs are executed.
TODO:
-> Vec<Complex64>methods on their parameter structs rather than free functions?